-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable two HTTP POST tests #94115
enable two HTTP POST tests #94115
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue Detailsfixes #1580 I have capture where the big upload took ~ 5minutes to complete. I don't know if that is my ISP, server load or infrastructure. So I enabled the tests and increased the default utmost for large posts.
|
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are large HTTP/2 POSTs against Kestrel, it's possibly an issue with Kestrel's default HTTP/2 window size being relatively small and static, so upload bandwidth will drop significantly with increased latency.
yes, I saw that - The TCP window would fill up and shrink to 0 frequently. |
outer loop tets failures unrelated. |
fixes #1580
I have capture where the big upload took ~ 5minutes to complete. I don't know if that is my ISP, server load or infrastructure. So I enabled the tests and increased the default utmost for large posts.
While it may seems excessive this is also OuterLoop test doing very large post to remote server so the actual performance may vary. I was running tests overnight in loop and I did not see failure after bumping the timeout up.