Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable two HTTP POST tests #94115

Merged
merged 1 commit into from
Oct 30, 2023
Merged

enable two HTTP POST tests #94115

merged 1 commit into from
Oct 30, 2023

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Oct 27, 2023

fixes #1580

I have capture where the big upload took ~ 5minutes to complete. I don't know if that is my ISP, server load or infrastructure. So I enabled the tests and increased the default utmost for large posts.
While it may seems excessive this is also OuterLoop test doing very large post to remote server so the actual performance may vary. I was running tests overnight in loop and I did not see failure after bumping the timeout up.

@wfurt wfurt added area-System.Net.Http test-enhancement Improvements of test source code labels Oct 27, 2023
@wfurt wfurt added this to the 9.0.0 milestone Oct 27, 2023
@wfurt wfurt requested a review from a team October 27, 2023 21:10
@wfurt wfurt self-assigned this Oct 27, 2023
@ghost
Copy link

ghost commented Oct 27, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #1580

I have capture where the big upload took ~ 5minutes to complete. I don't know if that is my ISP, server load or infrastructure. So I enabled the tests and increased the default utmost for large posts.
While it may seems excessive this is also OuterLoop test doing very large post to remote server so the actual performance may vary. I was running tests overnight in loop and I did not see failure after bumping the timeout up.

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Http, test-enhancement

Milestone: 9.0.0

@wfurt
Copy link
Member Author

wfurt commented Oct 27, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are large HTTP/2 POSTs against Kestrel, it's possibly an issue with Kestrel's default HTTP/2 window size being relatively small and static, so upload bandwidth will drop significantly with increased latency.

@wfurt
Copy link
Member Author

wfurt commented Oct 28, 2023

yes, I saw that - The TCP window would fill up and shrink to 0 frequently.

@wfurt
Copy link
Member Author

wfurt commented Oct 30, 2023

outer loop tets failures unrelated.

@wfurt wfurt merged commit c9a985d into dotnet:main Oct 30, 2023
169 of 174 checks passed
@wfurt wfurt deleted the remote branch October 30, 2023 16:30
@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP2: Two remote server tests occasionally timing out in CI
2 participants