Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable two HTTP POST tests #94115

Merged
merged 1 commit into from
Oct 30, 2023
Merged

enable two HTTP POST tests #94115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.RemoteServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,14 +671,6 @@ public async Task PostAsync_Redirect_ResultingGetFormattedCorrectly(Configuratio
[Theory, MemberData(nameof(RemoteServersMemberData))]
public async Task PostAsync_RedirectWith307_LargePayload(Configuration.Http.RemoteServer remoteServer)
{
if (remoteServer.HttpVersion == new Version(2, 0))
{
// This is occasionally timing out in CI with SocketsHttpHandler and HTTP2, particularly on Linux
// Likely this is just a very slow test and not a product issue, so just increasing the timeout may be the right fix.
// Disable until we can investigate further.
return;
}

await PostAsync_Redirect_LargePayload_Helper(remoteServer, 307, true);
}

Expand Down Expand Up @@ -722,7 +714,9 @@ private async Task PostAsync_Redirect_LargePayload_Helper(Configuration.Http.Rem
content.Headers.ContentMD5 = TestHelper.ComputeMD5Hash(contentBytes);
}

using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
using HttpClient client = CreateHttpClientForRemoteServer(remoteServer);
client.Timeout = TimeSpan.FromMinutes(10);

using (HttpResponseMessage response = await client.PostAsync(redirectUri, content))
{
try
Expand Down
6 changes: 2 additions & 4 deletions src/libraries/Common/tests/System/Net/Http/PostScenarioTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,9 @@ public async Task PostLargeContentUsingContentLengthSemantics_Success(Configurat
[Theory, MemberData(nameof(RemoteServersMemberData))]
public async Task PostRewindableContentUsingAuth_NoPreAuthenticate_Success(Configuration.Http.RemoteServer remoteServer)
{
if (remoteServer.HttpVersion == new Version(2, 0))
// Sync API supported only up to HTTP/1.1
if (!TestAsync && remoteServer.HttpVersion.Major >= 2)
{
// This is occasionally timing out in CI with SocketsHttpHandler and HTTP2, particularly on Linux
// Likely this is just a very slow test and not a product issue, so just increasing the timeout may be the right fix.
// Disable until we can investigate further.
return;
}

Expand Down
Loading