[browser] Minimal legacy support for Blazor renderBatch #95869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis will allow us to reduce dependency of Blazor internal on legacy interop to last 2 methods. Contributes to dotnet/aspnetcore#48042
|
kg
reviewed
Dec 11, 2023
kg
approved these changes
Dec 11, 2023
radical
reviewed
Dec 11, 2023
|
@pavelsavara Would it be correct to think that a test can be added only once the other linked PRs, that use the bits added here, get merged? |
This was referenced Dec 11, 2023
kg
requested changes
Dec 12, 2023
ghost
added
the
needs-author-action
ghost
removed
the
needs-author-action
kg
approved these changes
Dec 12, 2023
I tested it locally together with local Blazor. This is core of Blazor rendering, so we would know pretty soon that I broke it. I hope they have tests for it. |
ilonatommy
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to reduce dependency of Blazor internal on legacy interop to last 2 methods.
Contributes to dotnet/aspnetcore#48042
To be used by dotnet/aspnetcore#52732