Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blazor][wasm] Remove legacy interop #52732

Merged
merged 4 commits into from
Jan 9, 2024
Merged

[blazor][wasm] Remove legacy interop #52732

merged 4 commits into from
Jan 9, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Dec 11, 2023 •
edited
Loading

  • drop obsolete C# API IJSUnmarshalledObjectReference and IJSUnmarshalledRuntime
  • drop invokeJSFromDotNet()
  • drop toUint8Array()
  • drop readFloatField()
  • drop getArrayLength()
  • stop using BINDING.conv_string and BINDING.unbox_mono_obj
  • use MONO_INTERNAL.monoStringToStringUnsafe and MONO_INTERNAL.monoObjectAsBoolOrNullUnsafe instead

Depends on dotnet/runtime#95869
Fixes #48042

@pavelsavara pavelsavara added area-blazor Includes: Blazor, Razor Components arch-wasm labels Dec 11, 2023
@pavelsavara pavelsavara added this to the .NET 9 Planning milestone Dec 11, 2023
@pavelsavara pavelsavara self-assigned this Dec 11, 2023
@pavelsavara pavelsavara requested a review from maraf December 11, 2023 17:41
@pavelsavara pavelsavara mentioned this pull request Dec 11, 2023
Merged
@pavelsavara

This comment was marked as outdated.

Sign in to view
@pavelsavara pavelsavara requested a review from javiercn January 3, 2024 15:32
@pavelsavara pavelsavara marked this pull request as ready for review January 3, 2024 15:32
@pavelsavara pavelsavara requested a review from a team as a code owner January 3, 2024 15:32
@pavelsavara
Copy link
Member Author

Unrelated CI failure in IdentityUIScriptsTest.IdentityUI_ScriptTags_SubresourceIntegrityCheck
Log

maraf
maraf approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@maraf maraf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

src/Components/Web.JS/src/Boot.WebAssembly.ts Show resolved Hide resolved
javiercn
javiercn approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@pavelsavara pavelsavara enabled auto-merge (squash) January 9, 2024 17:48
@pavelsavara pavelsavara merged commit c376589 into dotnet:main Jan 9, 2024
26 checks passed
@ghost ghost modified the milestones: .NET 9 Planning, 9.0-preview1 Jan 9, 2024
@pavelsavara pavelsavara mentioned this pull request Jan 11, 2024
Merged
This was referenced Mar 1, 2024
Merged
Open
@pavelsavara pavelsavara mentioned this pull request Oct 22, 2024
Closed
1 task
@maraf maraf mentioned this pull request Nov 14, 2024
Closed
@peterthorpe81 peterthorpe81 mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraf maraf maraf approved these changes

@javiercn javiercn javiercn approved these changes

@MackinnonBuck MackinnonBuck Awaiting requested review from MackinnonBuck

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
9.0-preview1
Development

Successfully merging this pull request may close these issues.

[blazor][wasm] Remaining legacy interop
3 participants
@pavelsavara @javiercn @maraf