-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] remove legacy js interop #96841
[browser] remove legacy js interop #96841
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsPublic
Internal
TODO
|
This comment was marked as outdated.
This comment was marked as outdated.
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
@radical |
You need an installer which references that version or newer of aspnetcore. We update the installer once a day via the darc flow. Just watch for that. |
The flow is |
maybe this #96896 |
fd9796d
to
9bc6437
Compare
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder, we left the legacy API in src/mono/wasm/Wasm.Build.Tests/data/test-main-7.0.js
but the "dotnet-latest" we use for running wbt will not contain it anymore. @radical, do we ever run wbt with older dotnet?
I filled #97217 for
|
No. We can drop any 7.0 stuff. |
it looks like this caused large blazor startup regression the range is |
The slowdown is strange, there is no new code in the startup sequence, just code removed. There is also 80 KB reduction in uncompressed size, right ? |
It might be something broken with the UI startup, the time is very close to 20 seconds. So I wonder if it is related to some timeout being set to 20s. The reduced size is great and is visible in the cold startup. |
I hope this will fix it #97305 Do we have same problem in the other benchmark suite too ? |
It is indeed a timeout
|
Public
MONO
andBINDING
JS APIsdisableDotnet6Compatibility
JS flagHEAP
XXX on emscripten moduledotnet-legacy.d.ts
WasmEnableLegacyJsInterop
and related trimming support for itmono_wasm_invoke_js_blazor()
andWebAssembly.JSInterop.InternalCalls.InvokeJS()
ICALInternal
Runtime
andJSObject
extensionsDataView
...System.Runtime.InteropServices.JavaScript.Legacy.Tests
timers.mjs
,TimerTests
HttpRequestMessageTest
System.Runtime.InteropServices.JavaScript.Tests
call_test_method
used in some testsTODO
bind_static_method
[browser][debugger] fake bind_static_method #96899Fixes #90044