Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] bump benchmarks to Net9 #97305

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 22, 2024

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jan 22, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Jan 22, 2024
@pavelsavara pavelsavara self-assigned this Jan 22, 2024
@pavelsavara pavelsavara requested a review from lewing as a code owner January 22, 2024 13:15
@ghost
Copy link

ghost commented Jan 22, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser

Milestone: 9.0.0

@@ -10,8 +10,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="8.0.0" />
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="8.0.0" PrivateAssets="all" />
<!-- TODO un-pin this when it's possible -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there better way than specific alpha version @akoeplinger ?
something that would flow the latest Blazor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will need to start creating the template on the fly with the dotnet new blazorwasm command and patching it with required changes.

The browser template measurement would benefit from the same approach too.

Copy link
Member

@maraf maraf Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something that would flow the latest Blazor

We would need a darc dependency, wouldn't we?

The browser template measurement would benefit from the same approach too.

@radekdoulik Why would would it be benefitial for wasmbrowser?

Copy link
Member

@akoeplinger akoeplinger Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need a darc dependency, wouldn't we?

Yeah but it would create a circular dependency between aspnetcore <-> runtime which we usually avoid.

Another way that should work is looking at the LatestRuntimeFrameworkVersion key on the Microsoft.AspNetCore.App KnownFrameworkReference which matches the current TFM since that should be whatever aspnetcore is included in the sdk.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radekdoulik Why would would it be benefitial for wasmbrowser?

Would it even help keep us up to date with latest or it's the same darc flow problem?

Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use it as quick fix to get new measurements.

I will fix the remaining issue with the package references in the following PR.

@pavelsavara pavelsavara merged commit 48ae7e1 into dotnet:main Jan 22, 2024
22 of 25 checks passed
@pavelsavara pavelsavara deleted the browser_fix_bench branch January 22, 2024 16:46
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
Co-authored-by: Radek Doulik <radek.doulik@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants