-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] bump benchmarks to Net9 #97305
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
@@ -10,8 +10,9 @@ | |||
</PropertyGroup> | |||
|
|||
<ItemGroup> | |||
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="8.0.0" /> | |||
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="8.0.0" PrivateAssets="all" /> | |||
<!-- TODO un-pin this when it's possible --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there better way than specific alpha version @akoeplinger ?
something that would flow the latest Blazor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will need to start creating the template on the fly with the dotnet new blazorwasm
command and patching it with required changes.
The browser template measurement would benefit from the same approach too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something that would flow the latest Blazor
We would need a darc dependency, wouldn't we?
The browser template measurement would benefit from the same approach too.
@radekdoulik Why would would it be benefitial for wasmbrowser?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need a darc dependency, wouldn't we?
Yeah but it would create a circular dependency between aspnetcore <-> runtime which we usually avoid.
Another way that should work is looking at the LatestRuntimeFrameworkVersion
key on the Microsoft.AspNetCore.App
KnownFrameworkReference
which matches the current TFM since that should be whatever aspnetcore is included in the sdk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radekdoulik Why would would it be benefitial for wasmbrowser?
Would it even help keep us up to date with latest or it's the same darc flow problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use it as quick fix to get new measurements.
I will fix the remaining issue with the package references in the following PR.
Co-authored-by: Radek Doulik <radek.doulik@gmail.com>
To fix #96841 (comment)