Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up illink suppressions #96361

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Clean up illink suppressions #96361

merged 7 commits into from
Jan 3, 2024

Commits on Dec 29, 2023

  1. Clean up illink suppressions

    @sbomer
    sbomer committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    d4caf44 View commit details
    Browse the repository at this point in the history

  2. Suppress IL2008

    @sbomer
    sbomer committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    17ba9ef View commit details
    Browse the repository at this point in the history

  3. Support multiple suppression xmls 

    CoreLib has a shared ILLink.Substitutions.LibraryBuild.xml, and
one that is specific to coreclr. Use an ItemGroup to support the use
of both.
    @sbomer
    sbomer committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    e2c9876 View commit details
    Browse the repository at this point in the history

  4. Suppress IL2035

    @sbomer
    sbomer committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    0e804dc View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Replace unnecessary "

    @sbomer
    sbomer committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    c541c37 View commit details
    Browse the repository at this point in the history

  2. PR feedback 

    - Keep properties in existing order
- Separate PropertyGroup/ItemGroup with blank lines
- Place all NoWarns on one line
    @sbomer
    sbomer committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    5c9bc36 View commit details
    Browse the repository at this point in the history

  3. Update eng/illink.targets 

    Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
    @sbomer @ViktorHofer
    sbomer and ViktorHofer authored Jan 2, 2024
    Configuration menu
    Copy the full SHA
    7d0b61b View commit details
    Browse the repository at this point in the history