Clean up illink suppressions #96361
Merged
Clean up illink suppressions #96361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Detailsnull
|
CoreLib has a shared ILLink.Substitutions.LibraryBuild.xml, and one that is specific to coreclr. Use an ItemGroup to support the use of both.
sbomer
requested review from
MichalStrehovsky,
vitek-karas,
ViktorHofer and
eerhardt
ViktorHofer
reviewed
Dec 30, 2023
ViktorHofer
reviewed
Dec 30, 2023
ViktorHofer
reviewed
Dec 30, 2023
ViktorHofer
reviewed
Dec 30, 2023
ViktorHofer
reviewed
Dec 30, 2023
eerhardt
reviewed
Jan 2, 2024
- Keep properties in existing order - Separate PropertyGroup/ItemGroup with blank lines - Place all NoWarns on one line
ViktorHofer
reviewed
Jan 2, 2024
ViktorHofer
approved these changes
Jan 2, 2024
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
eerhardt
approved these changes
Jan 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warnings suppressed in #96327 were not observed in dotnet/runtime because:
The per-library trimming phase still had a bunch of analysis warnings suppressed that were never removed as part of #38033. This removes the NoWarn suppressions, and fixes up the ILLink.Suppressions.LibraryBuild.xml logic so that these xml suppressions get used during the library build. Since corelib has two separate suppression files (one shared, and one for coreclr), this changes the logic to allow multiple suppression xml files.