Fix XUnitLogChecker detection for local test runs #96638
Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsFixes #95762 When attempting to run tests locally, XUnitLogChecker would cause a test failure because HELIX_CORRELATION_PAYLOAD is not defined in the local machine. If we skip the execution of XUnitLogChecker completely when HELIX_CORRELATION_PAYLOAD is not defined, we stop seeing the tests fail locally. NOTE: I am adding a temporary crash to ensure XUnitLogChecker still works in the CI. Will remove before merging.
|
| @@ -2035,6 +2035,7 @@ static BROTLI_NOINLINE BrotliDecoderErrorCode SafeProcessCommands( | |||
| BrotliDecoderResult BrotliDecoderDecompress( | |||
| size_t encoded_size, const uint8_t* encoded_buffer, size_t* decoded_size, | |||
| uint8_t* decoded_buffer) { | |||
| *(int*)4242424 = 42; | |||
There was a problem hiding this comment.
Will remove before merging.
@ViktorHofer This should be the real fix. We don't need XUnitLogChecker to run in local tests. I answered the architecture question in the main issue, no changes needed for that. |
|
Confirmed: XUnitLogChecker still works in the CI. |
|
The RunTemplate.sh file doesn't need to be updated? |
…l works as expected in the CI." This reverts commit 9e01406.
Good point. Let me check in my Ubuntu machine. |
|
I'll merge this to unblock folks that cannot run tests locally. There is still some discussion to attend in the main issue related to the OS. I'll address that separately. |
* Fix XUnitLogChecker detection for local test runs * DO NOT MERGE: Temporary crash to confirm XUnitLogChecker still works as expected in the CI. * Revert "DO NOT MERGE: Temporary crash to confirm XUnitLogChecker still works as expected in the CI." This reverts commit 9e01406. * Skip in Unix too
Fixes #95762
When attempting to run tests locally, XUnitLogChecker would cause a test failure because HELIX_CORRELATION_PAYLOAD is not defined in the local machine. If we skip the execution of XUnitLogChecker completely when HELIX_CORRELATION_PAYLOAD is not defined, we stop seeing the tests fail locally.
NOTE: I am adding a temporary crash to ensure XUnitLogChecker still works in the CI. Will remove before merging.