Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XUnitLogChecker detection for local test runs #96638

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Fix XUnitLogChecker detection for local test runs #96638

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e31358
Fix XUnitLogChecker detection for local test runs
carlossanlop Jan 8, 2024
9e01406
DO NOT MERGE: Temporary crash to confirm XUnitLogChecker still works …
carlossanlop Jan 8, 2024
d71a096
Revert "DO NOT MERGE: Temporary crash to confirm XUnitLogChecker stil…
carlossanlop Jan 8, 2024
6d4832e
Skip in Unix too
carlossanlop Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions eng/testing/RunnerTemplate.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ if %_exit_code%==1 (
)
)

if "%HELIX_CORRELATION_PAYLOAD%"=="" (
GOTO SKIP_XUNITLOGCHECKER
)
if NOT "%__IsXUnitLogCheckerSupported%"=="1" (
echo XUnitLogChecker not supported for this test case. Skipping.
GOTO SKIP_XUNITLOGCHECKER
Expand Down
1 change: 1 addition & 0 deletions src/native/external/brotli/dec/decode.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2035,6 +2035,7 @@ static BROTLI_NOINLINE BrotliDecoderErrorCode SafeProcessCommands(
BrotliDecoderResult BrotliDecoderDecompress(
size_t encoded_size, const uint8_t* encoded_buffer, size_t* decoded_size,
uint8_t* decoded_buffer) {
*(int*)4242424 = 42;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove before merging.

BrotliDecoderState s;
BrotliDecoderResult result;
size_t total_out = 0;
Expand Down
Loading