Don't shorten OCSP expriation on failed server OCSP fetch #96972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones Issue DetailsFollow up on #96448. Minor bug in the original implementation could potentially drop a still valid OCSP staple if we fail to refresh. The scenario is as follows:
The original intent of setting This PR makes sure we don't shorten the
|
rzikm
force-pushed
the
ocsp-exipration-cut
branch
from
496896a to
cf5c52d
Compare
rzikm
force-pushed
the
ocsp-exipration-cut
branch
from
cf5c52d to
13acf6d
Compare
bartonjs
reviewed
Jan 16, 2024
src/libraries/System.Net.Security/src/System/Net/Security/SslStreamCertificateContext.Linux.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Jan 16, 2024
wfurt
pushed a commit
to rzikm/dotnet-runtime
that referenced
this pull request
Jan 16, 2024
* Don't shorten OCSP expriation on failed server OCSP fetch * Code review feedback
wfurt
pushed a commit
to rzikm/dotnet-runtime
that referenced
this pull request
Jan 16, 2024
* Don't shorten OCSP expriation on failed server OCSP fetch * Code review feedback
wfurt
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add entire issuer chain to trusted X509_STORE when stapling OCSP_Response (#96792) * Add entire issuer chain to trusted X509_STORE when validating OCSP_Response * Code review feedback * More code review feedback * Update src/libraries/System.Net.Security/src/System/Net/Security/SslStreamCertificateContext.Linux.cs Co-authored-by: Jeremy Barton <jbarton@microsoft.com> * Fix compilation * Always include root certificate --------- Co-authored-by: Jeremy Barton <jbarton@microsoft.com> * Recover from failed OCSP download. (#96448) * Recover from failed OCSP check. * Add 5s back-off after failed OCSP querry * Don't shorten OCSP expriation on failed server OCSP fetch (#96972) * Don't shorten OCSP expriation on failed server OCSP fetch * Code review feedback --------- Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
rzikm
added a commit
that referenced
this pull request
Jan 16, 2024
* Recover from failed OCSP download. (#96448) * Recover from failed OCSP check. * Add 5s back-off after failed OCSP querry * Do not OCSP staple invalid OCSP responses * Add entire issuer chain to trusted X509_STORE when validating OCSP_Response Code review feedback More code review feedback Update src/libraries/System.Net.Security/src/System/Net/Security/SslStreamCertificateContext.Linux.cs Co-authored-by: Jeremy Barton <jbarton@microsoft.com> Fix compilation Always include root certificate * Fix compilation * Don't shorten OCSP expriation on failed server OCSP fetch (#96972) * Don't shorten OCSP expriation on failed server OCSP fetch * Code review feedback --------- Co-authored-by: Kevin Jones <kevin@vcsjones.com> Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
* Don't shorten OCSP expriation on failed server OCSP fetch * Code review feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #96448.
Minor bug in the original implementation could potentially drop a still valid OCSP staple if we fail to refresh. The failing scenario is as follows:
_nextDownloadand_ocspExpirationget set to 5 seconds into the future to facilitate retry with a 5s backoff_ocspExpirationis in the past and we stop sending the original staple.The original intent of setting
_ocspExpirationwas to avoid immediate refetch if we fail on the very first OCSP fetch.This PR makes sure we don't shorten the
_ocspExpiration