Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't shorten OCSP expriation on failed server OCSP fetch #96972

Merged
merged 2 commits into from
Jan 16, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,15 @@ partial void AddRootCertificate(X509Certificate2? rootCertificate, ref bool tran
// Note that if server does not send OCSP staples, clients may still
// contact OCSP responders directly.
_nextDownload = DateTimeOffset.UtcNow.AddSeconds(5);
_ocspExpiration = _nextDownload;

if (_ocspExpiration < _nextDownload)
{
// this prevent forced download on next call if called before _nextDownload.
_ocspExpiration = _nextDownload;

// Drop the cached OCSP response, it expires in next few seconds anyway.
_ocspResponse = null;
rzikm marked this conversation as resolved.
Show resolved Hide resolved
}
}
return ret;
}
Expand Down
Loading