Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use insGetPredicateType for SVE encodings #97142

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Use insGetPredicateType for SVE encodings #97142

merged 4 commits into from
Jan 19, 2024

Conversation

a74nh
Copy link
Contributor

@a74nh a74nh commented Jan 18, 2024 •
edited
Loading

As suggested in #96992

Replaces uses of PredicateType in emitDispInsHelp() with uses of insGetPredicateType()

Only group IF_SVE_AH_3A remains (due to the encoding not being fixed).

No new diffs in the coreclr vs capstone output

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 18, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 18, 2024
@a74nh
Copy link
Contributor Author

a74nh commented Jan 18, 2024

@kunalspathak

@ghost
Copy link

ghost commented Jan 18, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

As suggested in #96992

Replaces uses of PredicateType in emitDispInsHelp() with uses of insGetPredicateType()

Only group IF_SVE_AH_3A remains (due to the encoding not being fixed).

Author: a74nh
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@a74nh a74nh mentioned this pull request Jan 18, 2024
Merged
This was referenced Jan 18, 2024
Open
Closed
@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Jan 18, 2024
@kunalspathak
Copy link
Member

@dotnet/arm64-contrib

kunalspathak
kunalspathak reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some nit comments to get your thoughts on.

src/coreclr/jit/emitarm64.cpp Show resolved Hide resolved
src/coreclr/jit/emitarm64.cpp Outdated Show resolved Hide resolved
src/coreclr/jit/emitarm64.cpp Outdated Show resolved Hide resolved
kunalspathak
kunalspathak approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak kunalspathak merged commit aca77bd into dotnet:main Jan 19, 2024
127 of 129 checks passed
@a74nh a74nh deleted the insGetPredicateType_github branch January 19, 2024 16:25
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@a74nh @tmds
Use insGetPredicateType for SVE encodings (dotnet#97142)
8c8a940 
* Use insGetPredicateType for SVE encodings

* Add predicate as counter printing

* Pass type to emitPredicateRegName
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a74nh @kunalspathak