Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report an error when using --skip-manifest-update and --from-rollback-file #24023

Closed
marcpopMSFT opened this issue Feb 18, 2022 · 2 comments · Fixed by #24512
Closed

Report an error when using --skip-manifest-update and --from-rollback-file #24023

marcpopMSFT opened this issue Feb 18, 2022 · 2 comments · Fixed by #24512
Assignees
@gkulin
Labels
Area-Workloads good first issue Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined.
Milestone
6.0.3xx

Comments

@marcpopMSFT
Copy link
Member

We added rollback files to the update command and skip manifest update to the install command. Later we add rollback to the install command but the two switches don't work well together.

We should trigger an error or at least a warning as --skip-manifest-update appear to take precedence.
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Feb 18, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@marcpopMSFT marcpopMSFT added good first issue Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined. Area-Workloads and removed untriaged Request triage from a team member labels Feb 18, 2022
@dsplaisted dsplaisted changed the title Report a warning when using --skip-manifest-update and --from-rollback-file Report an error when using --skip-manifest-update and --from-rollback-file Mar 3, 2022
@dsplaisted dsplaisted added this to the 6.0.3xx milestone Mar 3, 2022
gkulin added a commit to gkulin/sdk that referenced this issue Mar 8, 2022
@gkulin
Fixes dotnet#24023
5287991
@benvillalobos benvillalobos mentioned this issue Mar 23, 2022
Merged
@marcpopMSFT
Copy link
Member Author

#24288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkulin gkulin

Labels
Area-Workloads good first issue Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined.
Projects
None yet
Milestone
6.0.3xx
Development

Successfully merging a pull request may close this issue.

Detect arm64 hostfxr.dll benvillalobos/sdk
3 participants
@dsplaisted @marcpopMSFT @gkulin