Detect arm64 hostfxr.dll #24512
Merged
Detect arm64 hostfxr.dll #24512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvillalobos
requested review from
ericstj,
a team,
joperezr,
captainsafia,
mkArtakMSFT,
donJoseLuis,
jmarolf,
JoeRobich,
TanayParikh and
javiercn
as code owners
|
cc @marcpopMSFT |
dsplaisted
approved these changes
Mar 23, 2022
I retried my local build with this check fully expecting this to fail so I could share the log, but I retried without the hostfxr-specificity and it built properly. Pushed up that change. |
benvillalobos
removed request for
a team,
JoeRobich,
captainsafia,
javiercn,
ericstj,
jmarolf,
joperezr,
TanayParikh and
mkArtakMSFT
kasperk81
reviewed
Mar 23, 2022
Comment on lines
42
to
+43
| string architecture = IntPtr.Size == 8 ? "x64" : "x86"; | ||
| architecture = RuntimeInformation.ProcessArchitecture == Architecture.Arm64 ? "arm64" : architecture; |
There was a problem hiding this comment.
why not:
Suggested change
| string architecture = IntPtr.Size == 8 ? "x64" : "x86"; | |
| architecture = RuntimeInformation.ProcessArchitecture == Architecture.Arm64 ? "arm64" : architecture; | |
| string architecture = Enum.GetName(RuntimeInformation.ProcessArchitecture).ToLowerInvariant(); |
There was a problem hiding this comment.
For the sake of time, I decided not to consider the other code paths it could potentially go down if it were on a different arch. Though I suspect this to be the better way to go about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help msbuild understand when it should load an arm64 hostfxr. I verified this works locally on an arm64 machine.
The check arm64 folder check should only run when finding
hostfxr, otherwise we crash later in the build.