Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0.3xx] Backport Improve console output of dotnet watch ⌚ (#23318) #23400

Merged
merged 5 commits into from
Jan 25, 2022
Merged

[release/6.0.3xx] Backport Improve console output of dotnet watch ⌚ (#23318) #23400

merged 5 commits into from
Jan 25, 2022

Conversation

TanayParikh
Copy link
Contributor

(cherry picked from commit 5ae5131)

Backports #23318

@TanayParikh
Improve console output of dotnet watch ⌚ (#23318)
0abb836 
* Requester

* Relative File Path

* Updated Rude Edit Dialog

* Emojify

* Tests

* Test fix 2 (ChangeExcludedFile still failing)

* Relative path robustness

* File changed test

* Arg based emojis

* Remove duplicate tip message

(cherry picked from commit 5ae5131)
@TanayParikh TanayParikh marked this pull request as ready for review January 12, 2022 20:05
pranavkm
pranavkm approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving backport change

@TanayParikh
Copy link
Contributor Author

@DamianEdwards just a fyi we may run into microsoft/terminal#190.

@DamianEdwards
Copy link
Member

@TanayParikh have you tried it in latest Windows Terminal? How does it look?

@TanayParikh
Copy link
Contributor Author

TanayParikh commented Jan 13, 2022 •
edited
Loading

@TanayParikh have you tried it in latest Windows Terminal? How does it look?

Pranav tried out emoji support it works fine in the latest Windows Terminal (powershell, cmd). The issue is with the old conhost based command prompt. I'll do a quick validation round in the new terminal with the dotnet watch utility before merging.

I'm also updating the PR to add a DOTNET_WATCH_SUPPRESS_EMOJIS environment variable to facilitate configurability.

The bunch of commits here are to do with some strange CI behavior between main and release/6.0.2xx (for some reason emoji encoding isn't working as expected in the 6.0.2xx CI).

@TanayParikh TanayParikh force-pushed the taparik/backport_5ae5131 branch 2 times, most recently from 436cb31 to 2d01f57 Compare January 14, 2022 03:14
@TanayParikh
Copy link
Contributor Author

I'll do a quick validation round in the new terminal with the dotnet watch utility before merging.

image

image

Looking good.

@TanayParikh TanayParikh mentioned this pull request Jan 15, 2022
Merged
@TanayParikh TanayParikh added the Blocked Issue is blocked on an external dependency label Jan 15, 2022
@marcpopMSFT marcpopMSFT added this to the 6.0.3xx milestone Jan 20, 2022
@TanayParikh TanayParikh changed the title [release/6.0.2xx] Backport Improve console output of dotnet watch ⌚ (#23318) [release/6.0.3xx] Backport Improve console output of dotnet watch ⌚ (#23318) Jan 20, 2022
@TanayParikh TanayParikh changed the base branch from release/6.0.2xx to release/6.0.3xx January 22, 2022 01:19
@TanayParikh TanayParikh enabled auto-merge (squash) January 22, 2022 01:26
@TanayParikh TanayParikh removed the Blocked Issue is blocked on an external dependency label Jan 22, 2022
@TanayParikh TanayParikh self-assigned this Jan 22, 2022
@TanayParikh TanayParikh merged commit 93c4356 into release/6.0.3xx Jan 25, 2022
@benvillalobos benvillalobos mentioned this pull request Mar 23, 2022
Merged
@TanayParikh TanayParikh deleted the taparik/backport_5ae5131 branch May 9, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianEdwards DamianEdwards DamianEdwards approved these changes

@pranavkm pranavkm pranavkm approved these changes

Assignees

@TanayParikh TanayParikh

Labels
Area-Infrastructure Area-Watch
Projects
None yet
Milestone
6.0.3xx
Development

Successfully merging this pull request may close these issues.
4 participants
@TanayParikh @DamianEdwards @pranavkm @marcpopMSFT