Update default TrimMode for WebSDK projects

[captainsafia]

Set TrimMode=full for web projects where PublishTrimmed=true.

Note: we could achieve the same effect by removing the property all together and relying on the defaults the linker targets set but I like the explicitness of this approach.

[DamianEdwards]

@captainsafia might be worth getting @agocke to check this too. Also, just to confirm, this should have on impact on Blazor WebAssembly projects right? They have to still use <TrimMode>partial</TrimMode> as I understand it.

[captainsafia]

might be worth getting @agocke to check this too.

Sure.

Also, just to confirm, this should have on impact on Blazor WebAssembly projects right? They have to still use partial as I understand it.

Yes, Blazor is unaffected. The fact that these tests pass helps us confirm this.

[eerhardt]

Also, just to confirm, this should have on impact on Blazor WebAssembly projects right? They have to still use <TrimMode>partial</TrimMode> as I understand it.

Blazor WASM sets it early in the project (in the .props file) here:

sdk/src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.Current.props

Lines 20 to 23 in 6446f88

	<!-- Trimmer defaults -->
	<PublishTrimmed Condition="'$(PublishTrimmed)' == ''">true</PublishTrimmed>
	<TrimMode Condition="'$(TrimMode)' == ''">partial</TrimMode>
	<TrimmerRemoveSymbols Condition="'$(TrimmerRemoveSymbols)' == ''">false</TrimmerRemoveSymbols>

[agocke]

LGTM, thanks!

Blazor may be worth a test somewhere -- I assume there's one in their repo.

[captainsafia]

LGTM, thanks!

Blazor may be worth a test somewhere -- I assume there's one in their repo.

Yes, here.

[eerhardt]

Uggh, I just realized that we probably should be leaving TrimMode=partial for TFMs below net8.0. I don't think we should be changing behavior for people when they upgrade their SDK. Only when they retarget from net6/7.0 => net8.0.