Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep TrimMode=partial for projects targeting .NET 7 or below #34030

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Keep TrimMode=partial for projects targeting .NET 7 or below #34030

merged 2 commits into from
Jul 18, 2023

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Jul 14, 2023 •
edited
Loading

Follow-up to #33962.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-WebSDK untriaged Request triage from a team member labels Jul 14, 2023
@captainsafia captainsafia force-pushed the safia/trim-mode-follow-up branch 4 times, most recently from 368f6fe to 6d4b377 Compare July 17, 2023 19:59
@captainsafia captainsafia force-pushed the safia/trim-mode-follow-up branch from 6d4b377 to 690297e Compare July 17, 2023 22:56
@captainsafia captainsafia added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch and removed Area-WebSDK labels Jul 18, 2023
@ghost
Copy link

ghost commented Jul 18, 2023

Thanks for your PR, @captainsafia.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@captainsafia captainsafia marked this pull request as ready for review July 18, 2023 00:12
@captainsafia captainsafia requested a review from vijayrkn as a code owner July 18, 2023 00:12
@captainsafia captainsafia requested a review from eerhardt July 18, 2023 01:09
eerhardt
eerhardt reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@captainsafia captainsafia enabled auto-merge (squash) July 18, 2023 16:13
@captainsafia captainsafia merged commit 52d9ab4 into main Jul 18, 2023
@captainsafia captainsafia deleted the safia/trim-mode-follow-up branch July 18, 2023 17:01
@eerhardt eerhardt mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@vijayrkn vijayrkn Awaiting requested review from vijayrkn vijayrkn is a code owner

Assignees
No one assigned
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captainsafia @eerhardt