Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove longstanding comment from C# console template #42497

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Merge branch 'main' into remove-comment-from-console-template

a711f17
Select commit
Loading
Failed to load commit list.
Open

Remove longstanding comment from C# console template #42497

Merge branch 'main' into remove-comment-from-console-template
a711f17
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis failed Sep 9, 2024 in 0s

.NET Result Analysis

Details

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

Known Repository Errors

Test Failures (7 tests failed)

🔹 [All failing tests from dotnet-sdk-public-ci]

    ⚠️ 5 failing tests not displayed for this pipeline due to space limitations

    Microsoft.DotNet.Cli.New.IntegrationTests.CommonTemplatesTests.FeaturesSupport [Details] [11.68% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configurations (3)

    Data Driven SubResults
      Microsoft.DotNet.Cli.New.IntegrationTests.CommonTemplatesTests.FeaturesSupport(name: \"console\", buildPass: True, framework: null, langVersion: null, langVersionUnsupported: False, language: null, supportsNullable: True, supportsTopLevel: True, forceDisableTopLevel: False, supportsImplicitUsings: True, supportsFileScopedNs: True)
      Exception Message
      Microsoft.TemplateEngine.Authoring.TemplateVerifier.TemplateVerificationException : Directory: /mnt/vss/_work/1/s/test/dotnet-new.Tests/Approvals\nNotEqual:\n  - Received: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.received/MyProject/Program.cs\n    Verified: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.verified/MyProject/Program.cs\nEqual:\n  - Received: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.received/MyProject/console.csproj\n    Verified: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.verified/MyProject/console.csproj\n  - Received: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.received/std-streams/stdout.txt\n    Verified: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.verified/std-streams/stdout.txt\n\nFileContent:\n\nNotEqual:\n\nReceived: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.received/MyProject/Program.cs\nVerified: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.verified/MyProject/Program.cs\nCompare Result:\n  [BOF]\n- // See https://aka.ms/new-console-template for more information\n1 Console.WriteLine(\"Hello, World!\");\n\n
      Stack Trace
         at Microsoft.TemplateEngine.Authoring.TemplateVerifier.VerificationEngine.VerifyResult(TemplateVerifierOptions args, IInstantiationResult commandResultData, CallerInfo callerInfo)
         at Microsoft.TemplateEngine.Authoring.TemplateVerifier.VerificationEngine.Execute(IOptions`1 optionsAccessor, CancellationToken cancellationToken, String sourceFile, String callerMethod)
         at Microsoft.DotNet.Cli.New.IntegrationTests.CommonTemplatesTests.FeaturesSupport(String name, Boolean buildPass, String framework, String langVersion, Boolean langVersionUnsupported, String language, Boolean supportsNullable, Boolean supportsTopLevel, Boolean forceDisableTopLevel, Boolean supportsImplicitUsings, Boolean supportsFileScopedNs) in /mnt/vss/_work/1/s/test/dotnet-new.Tests/CommonTemplatesTests.cs:line 417
      --- End of stack trace from previous location ---
      Microsoft.DotNet.Cli.New.IntegrationTests.CommonTemplatesTests.FeaturesSupport(name: \"console\", buildPass: True, framework: null, langVersion: null, langVersionUnsupported: False, language: \"C#\", supportsNullable: True, supportsTopLevel: True, forceDisableTopLevel: False, supportsImplicitUsings: True, supportsFileScopedNs: True)
      Exception Message
      Microsoft.TemplateEngine.Authoring.TemplateVerifier.TemplateVerificationException : Directory: /mnt/vss/_work/1/s/test/dotnet-new.Tests/Approvals\nNotEqual:\n  - Received: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.received/MyProject/Program.cs\n    Verified: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.verified/MyProject/Program.cs\nEqual:\n  - Received: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.received/MyProject/console.csproj\n    Verified: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.verified/MyProject/console.csproj\n  - Received: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.received/std-streams/stdout.txt\n    Verified: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.verified/std-streams/stdout.txt\n\nFileContent:\n\nNotEqual:\n\nReceived: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.received/MyProject/Program.cs\nVerified: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-True#FileScopedNs-True#cs#NoLangVer.verified/MyProject/Program.cs\nCompare Result:\n  [BOF]\n- // See https://aka.ms/new-console-template for more information\n1 Console.WriteLine(\"Hello, World!\");\n\n
      Stack Trace
         at Microsoft.TemplateEngine.Authoring.TemplateVerifier.VerificationEngine.VerifyResult(TemplateVerifierOptions args, IInstantiationResult commandResultData, CallerInfo callerInfo)
         at Microsoft.TemplateEngine.Authoring.TemplateVerifier.VerificationEngine.Execute(IOptions`1 optionsAccessor, CancellationToken cancellationToken, String sourceFile, String callerMethod)
         at Microsoft.DotNet.Cli.New.IntegrationTests.CommonTemplatesTests.FeaturesSupport(String name, Boolean buildPass, String framework, String langVersion, Boolean langVersionUnsupported, String language, Boolean supportsNullable, Boolean supportsTopLevel, Boolean forceDisableTopLevel, Boolean supportsImplicitUsings, Boolean supportsFileScopedNs) in /mnt/vss/_work/1/s/test/dotnet-new.Tests/CommonTemplatesTests.cs:line 417
      --- End of stack trace from previous location ---
      Microsoft.DotNet.Cli.New.IntegrationTests.CommonTemplatesTests.FeaturesSupport(name: \"console\", buildPass: True, framework: null, langVersion: \"9.0\", langVersionUnsupported: False, language: null, supportsNullable: True, supportsTopLevel: True, forceDisableTopLevel: False, supportsImplicitUsings: False, supportsFileScopedNs: False)
      Exception Message
      Microsoft.TemplateEngine.Authoring.TemplateVerifier.TemplateVerificationException : Directory: /mnt/vss/_work/1/s/test/dotnet-new.Tests/Approvals\nNotEqual:\n  - Received: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-False#FileScopedNs-False#cs.received/MyProject/Program.cs\n    Verified: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-False#FileScopedNs-False#cs.verified/MyProject/Program.cs\nEqual:\n  - Received: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-False#FileScopedNs-False#cs.received/MyProject/console.csproj\n    Verified: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-False#FileScopedNs-False#cs.verified/MyProject/console.csproj\n  - Received: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-False#FileScopedNs-False#cs.received/std-streams/stdout.txt\n    Verified: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-False#FileScopedNs-False#cs.verified/std-streams/stdout.txt\n\nFileContent:\n\nNotEqual:\n\nReceived: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-False#FileScopedNs-False#cs.received/MyProject/Program.cs\nVerified: FeaturesSupport.console.Nullable-True#TopLevel-True#ImplicitUsings-False#FileScopedNs-False#cs.verified/MyProject/Program.cs\nCompare Result:\n  [BOF]\n- // See https://aka.ms/new-console-template for more information\n1 using System;\n\n
      Stack Trace
         at Microsoft.TemplateEngine.Authoring.TemplateVerifier.VerificationEngine.VerifyResult(TemplateVerifierOptions args, IInstantiationResult commandResultData, CallerInfo callerInfo)
         at Microsoft.TemplateEngine.Authoring.TemplateVerifier.VerificationEngine.Execute(IOptions`1 optionsAccessor, CancellationToken cancellationToken, String sourceFile, String callerMethod)
         at Microsoft.DotNet.Cli.New.IntegrationTests.CommonTemplatesTests.FeaturesSupport(String name, Boolean buildPass, String framework, String langVersion, Boolean langVersionUnsupported, String language, Boolean supportsNullable, Boolean supportsTopLevel, Boolean forceDisableTopLevel, Boolean supportsImplicitUsings, Boolean supportsFileScopedNs) in /mnt/vss/_work/1/s/test/dotnet-new.Tests/CommonTemplatesTests.cs:line 417
      --- End of stack trace from previous location ---
    Microsoft.NET.Build.Containers.IntegrationTests.PackageTests.PackageContentTest [Console] [Details] [Artifacts] [0.06% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configurations (4)

    Exception Message
    Expected root to be a collection with 59 item(s) because Microsoft.NET.Build.Containers.10.0.100-ci.nupkg content differs from expected. Please add the entry to the list, if the addition is expected., but {"_rels/.rels", "[Content_Types].xml", "build/Microsoft.NET.Build.Containers.buildschema.json", "build/Microsoft.NET.Build.Containers.props", "build/Microsoft.NET.Build.Containers.targets", "containerize/containerize.dll", "containerize/containerize.runtimeconfig.json", "containerize/Microsoft.DotNet.Cli.Utils.dll", "containerize/Microsoft.Extensions.Configuration.Abstractions.dll", "containerize/Microsoft.Extensions.Configuration.Binder.dll", "containerize/Microsoft.Extensions.Configuration.dll", "containerize/Microsoft.Extensions.DependencyInjection.Abstractions.dll", "containerize/Microsoft.Extensions.DependencyInjection.dll", "containerize/Microsoft.Extensions.DependencyModel.dll", "containerize/Microsoft.Extensions.Logging.Abstractions.dll", "containerize/Microsoft.Extensions.Logging.Configuration.dll", "containerize/Microsoft.Extensions.Logging.Console.dll", "containerize/Microsoft.Extensions.Logging.dll", "containerize/Microsoft.Extensions.Options.ConfigurationExtensions.dll", "containerize/Microsoft.Extensions.Options.dll", "containerize/Microsoft.Extensions.Primitives.dll", "containerize/Microsoft.NET.Build.Containers.dll", "containerize/Newtonsoft.Json.dll", "containerize/NuGet.Common.dll", "containerize/NuGet.Configuration.dll", "containerize/NuGet.DependencyResolver.Core.dll", "containerize/NuGet.Frameworks.dll", "containerize/NuGet.LibraryModel.dll", "containerize/NuGet.Packaging.dll", "containerize/NuGet.ProjectModel.dll", "containerize/NuGet.Protocol.dll", "containerize/NuGet.Versioning.dll", …28 more…}
    contains 1 item(s) more than
    {"_rels/.rels", "[Content_Types].xml", "build/Microsoft.NET.Build.Containers.props", "build/Microsoft.NET.Build.Containers.targets", "containerize/containerize.dll", "containerize/containerize.runtimeconfig.json", "containerize/Microsoft.DotNet.Cli.Utils.dll", "containerize/Microsoft.Extensions.Configuration.Abstractions.dll", "containerize/Microsoft.Extensions.Configuration.Binder.dll", "containerize/Microsoft.Extensions.Configuration.dll", "containerize/Microsoft.Extensions.DependencyInjection.Abstractions.dll", "containerize/Microsoft.Extensions.DependencyInjection.dll", "containerize/Microsoft.Extensions.DependencyModel.dll", "containerize/Microsoft.Extensions.Logging.Abstractions.dll", "containerize/Microsoft.Extensions.Logging.Configuration.dll", "containerize/Microsoft.Extensions.Logging.Console.dll", "containerize/Microsoft.Extensions.Logging.dll", "containerize/Microsoft.Extensions.Options.ConfigurationExtensions.dll", "containerize/Microsoft.Extensions.Options.dll", "containerize/Microsoft.Extensions.Primitives.dll", "containerize/Microsoft.NET.Build.Containers.dll", "containerize/Newtonsoft.Json.dll", "containerize/NuGet.Common.dll", "containerize/NuGet.Configuration.dll", "containerize/NuGet.DependencyResolver.Core.dll", "containerize/NuGet.Frameworks.dll", "containerize/NuGet.LibraryModel.dll", "containerize/NuGet.Packaging.dll", "containerize/NuGet.ProjectModel.dll", "containerize/NuGet.Protocol.dll", "containerize/NuGet.Versioning.dll", "containerize/System.CommandLine.dll", …27 more…}.
    

    With configuration:

    • Use declared types and members

    • Compare enums by value

    • Compare tuples by their properties

    • Compare anonymous types by their properties

    • Compare records by their members

    • Include non-browsable members

    • Include all non-private properties

    • Include all non-private fields

    • Match member by name (or throw)

    • Be strict about the order of items in byte arrays

    • Without automatic conversion.

    CallStack
       at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
     at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
     at FluentAssertions.Execution.CollectingAssertionStrategy.ThrowIfAny(IDictionary`2 context)
     at FluentAssertions.Execution.AssertionScope.Dispose()
     at FluentAssertions.Equivalency.EquivalencyValidator.AssertEquality(Comparands comparands, EquivalencyValidationContext context)
     at FluentAssertions.Equivalency.EquivalencyValidator.AssertEquality(Comparands comparands, EquivalencyValidationContext context)
     at FluentAssertions.Collections.StringCollectionAssertions`2.BeEquivalentTo(IEnumerable`1 expectation, Func`2 config, String because, Object[] becauseArgs)
     at FluentAssertions.Collections.StringCollectionAssertions`2.BeEquivalentTo(IEnumerable`1 expectation, String because, Object[] becauseArgs)
     at Microsoft.NET.Build.Containers.IntegrationTests.PackageTests.PackageContentTest() in /_/test/Microsoft.NET.Build.Containers.IntegrationTests/PackageTests.cs:line 142
     at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
     at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Was this helpful? Yes No