Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove longstanding comment from C# console template #42497

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove longstanding comment from C# console template #42497

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfce2bc
Update Program.cs
baronfel Aug 1, 2024
23d81ef
Merge branch 'main' into remove-comment-from-console-template
baronfel Aug 21, 2024
9a1df5a
Remove more template expectations
baronfel Aug 23, 2024
0876982
fix more tests
baronfel Aug 24, 2024
a711f17
Merge branch 'main' into remove-comment-from-console-template
baronfel Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Containers/packaging/build/Microsoft.NET.Build.Containers.buildschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"properties": {
"EnableSdkContainerSupport": {
"type": "bool",
"defaultValue": "false",
"description": "Enables the ability to package a project in a container. This is enabled by default if the project is an ASP.NET project or a Worker Project, or if the project includes a references to the Microsoft.NET.Build.Containers package."
},
"ContainerBaseImage": {
"type": "string",
"defaultValue": "mcr.microsoft.com/dotnet/runtime:8.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.0 intentional since this is main?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that file shouldn't even be checked in, it's not relevant to this template change at all. Let me revert it.

"description": "The base image to build the application container onto. If not specified the SDK will infer the best base image for your application.",
"helpUrl": "https://github.com/dotnet/sdk-container-builds/blob/main/docs/ContainerCustomization.md#containerbaseimage"
}
}
}
5 changes: 1 addition & 4 deletions ...Microsoft.DotNet.Common.ProjectTemplates.9.0/content/ConsoleApplication-CSharp/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
#if (csharpFeature_TopLevelProgram)
// See https://aka.ms/new-console-template for more information
#endif
#if (!csharpFeature_ImplicitUsings)
#if (!csharpFeature_ImplicitUsings)
using System;

#endif
Expand Down
3 changes: 1 addition & 2 deletions test/dotnet-new.Tests/Approvals/AotVariants.console.cs.verified/MyProject/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
// See https://aka.ms/new-console-template for more information
Console.WriteLine("Hello, World!");
Console.WriteLine("Hello, World!");
3 changes: 1 addition & 2 deletions test/dotnet-new.Tests/Approvals/AotVariants.console.vb.verified/MyProject/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
// See https://aka.ms/new-console-template for more information
Console.WriteLine("Hello, World!");
Console.WriteLine("Hello, World!");
Loading