[release/9.0.1xx] Using ConsoleLogger to prevent unexpected behavior #45015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-CLI
untriaged
MichalPavlik
changed the title
JanKrivanek
approved these changes
Nov 21, 2024
YuliiaKovalova
approved these changes
Nov 21, 2024
baronfel
approved these changes
Nov 21, 2024
|
Also needs to be backported to the internal 101 release branch. |
marcpopMSFT
pushed a commit
that referenced
this pull request
Nov 22, 2024
…xpected behavior (#45015) Cherry-pick #45015 to the 9.0.101 hotfix branch to ensure the change makes it to the hotfix. ---- #### AI description (iteration 1) #### PR Classification Bug fix #### PR Summary This pull request addresses unexpected behavior by replacing the `TerminalLogger` with `ConsoleLogger` as a temporary fix for version 9.0.1xx. - `src/Cli/dotnet/commands/dotnet-run/RunCommand.cs`: Replaced `TerminalLogger` with `ConsoleLogger` to prevent unexpected behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/msbuild#10998
Summary
dotnet rundirectly creates an instance ofTerminalLogger, bypassing all checks. This can lead to situations where ANSI escape sequences are emitted to the terminal, even if the terminal does not support them. These escape sequences are also emitted when the standard output is redirected, which can break a CI build that relies on the command's output.Changes Made
Minimal hotfix: The
ConsoleLoggeris used instead ofTerminalLoggerfor this SDK version.Customer Impact
Some customers reported unexpected behavior of
dotnet runcommand and CI builds failures.Regression?
Yes.
Testing
Manual testing with locally updated SDK.
Notes
There is a proper fix created for 9.0.2xx. This change shouldn't flow to higher versions.