Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.1xx] Using ConsoleLogger to prevent unexpected behavior #45015

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[release/9.0.1xx] Using ConsoleLogger to prevent unexpected behavior #45015

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93227c6
Using ConsoleLogger to prevent unexpected behavior
MichalPavlik Nov 21, 2024
6e33bf3
Merge branch 'release/9.0.1xx' into dev/mipavlik/fix-dotnet-run-901xx
MichalPavlik Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Cli/dotnet/commands/dotnet-run/RunCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,9 @@ public void Shutdown()
static ILogger MakeTerminalLogger(VerbosityOptions? verbosity)
{
var msbuildVerbosity = ToLoggerVerbosity(verbosity);
var thing = Assembly.Load("MSBuild").GetType("Microsoft.Build.Logging.TerminalLogger.TerminalLogger")!.GetConstructor([typeof(LoggerVerbosity)])!.Invoke([msbuildVerbosity]) as ILogger;

// Temporary fix for 9.0.1xx. 9.0.2xx will use the TerminalLogger in the safe way.
var thing = new ConsoleLogger(msbuildVerbosity);
return thing!;
}

Expand Down
Loading