[release/9.0.1xx] [FIX] tool-update: Compare tool versions correctly #45383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
edvilme
force-pushed
the
backport/pr-44517-to-release/9.0.1xx
branch
from
a351365 to
7779d50
Compare
edvilme
force-pushed
the
backport/pr-44517-to-release/9.0.1xx
branch
from
7779d50 to
50f3c47
Compare
This was referenced Dec 12, 2024
|
@edvilme can you prep the tactics template and set to servicing consider in Jan. We'll take for 9.0.103 for Feb release. |
edvilme
force-pushed
the
backport/pr-44517-to-release/9.0.1xx
branch
from
50f3c47 to
8c07f4f
Compare
marcpopMSFT
approved these changes
Jan 15, 2025
marcpopMSFT
added
Servicing-approved
and removed
Servicing-consider
untriaged
|
Approved over email |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #44517 to release/9.0.1xx
Customer Impact/Description
When updating a tool, versions are not compared correctly, making it impossible for users to update their tools to new minor versions. This means users are unable to update a tool from version
1.0.0-previewto version1.0.0for example. (see #43089)The introduced behavior compares the versions correctly, meaning users should now be able to update their tools.
Risk
Low - the version comparison is used to avoid installing already existing versions. This is the expected behavior.
Regression?
No. This is introduced for 9.0.1xx
Testing
New automated tests were added for installing newer minor versions of tools. Did manual testing to make sure tool was updated correctly between minor versions.
/cc @edvilme