Remove linker repo '-h' patch adding reflection heuristics #777
Comments
This was referenced Sep 17, 2018
|
Might end up being taken by Linker after all; dotnet/linker#626. |
|
@dagood The patch should no longer be required with the latest linker updates. We're using sources straight from mono/linker now. |
dseefeld
added a commit
to dseefeld/source-build
that referenced
this issue
Mar 20, 2020
dseefeld
added a commit
that referenced
this issue
Apr 8, 2020
* Update arcade and standard shas * Add runtime repo and remove coreclr, corefx and core-setup * Update standard to build with new arcade version * Update version of roslyn to work with updated Arcade * Update patches to enable runtime repo to build * Update aspnet-extensions commit and get it building * Add runtime portable build * Add OverrideTargetRid for Linux * Retain portable logs when cleaning up after portable build * Include project.assets.json files in files to be saved from portable build * Update version of source-build archive * Remove old corefx, coreclr and core-setup projects and update known-good * Add patch for ilasm round trip issue * Add patch for ilasm round trip issue * Update commit shas for repos in known good for preview 2 * Reconcile patches for core-sdk * Reconcile patches for linkere * Reconcile patches for fsharp repo * Reconcile patches for nuget-client repo * Reconcile patches for roslyn repo * Reconcile patches for runtime repo * Reconcile patches for sdk repo * Remove dependency flow sources -- update Arcade version * Update commit sha for standard * Update Arcade and SDK versions * Reconcile patches for arcade repo * Remove ArcadeConfigurationOverride * Fixup output placement for standard repo * Remove unneccessary roslyn patch * Correct invalid merge * Remove linker reflection heuristics patch per comment from sbomer on #777 * Update PackagesOutput for linker * Add patch to set nopgooptimize in coreclr build * Update coreclr build arguments * Only build through coreclr for now * Only build through runtime * Add CentOS 8 CI build (#1539) * Add CentOS 8 CI build We have had some issues building in RHEL 8, so lets set up a CentOS 8 CI system to try and catch those issues earlier. * Pin to artifacts version with executable coreclr bits Co-authored-by: Aditya Aggarwal <aditya.aggarwal@microsoft.com> Conflicts: eng/Versions.props repos/coreclr.common.props * Update docker images * Update version of xliff tasks * Include 1 addtional arcade patch * Add patch to exclude Helix tests from source-build in arcade * Add reference to PlatformAbstractions * Skip prebuilt check for now * Update version of previously source-built archive * Update online prebuilt baseline * Disable smoke-tests and unit tests until core-sdk build works * Don't remove placeholder pdb files * Add back temporary ildasm workaround until AspNetCore builds * Update baseline with OSX only prebuilts * Update offline baseline * Turn off processing of smoke-test-packages * Update debian & ubuntu images and turn off leak detection * Update Centos8 docker image to one that includes updated cmake * Another try at updating the centos8 docker image * Update to latest version of Private.SourceBuild.ReferencePackages * Remove detection of and de-assemble/re-assemble of read only ref pkgs With the completion of #1497, the need to detect and remove these read only ref packages has been removed. All packages that we have identified as read-only in the past have been included in source-build-reference-packages. If any new ones show up, they will show up as prebuilts and can be added to the source-build-reference-packages repo. * Revert "Skip prebuilt check for now" This reverts commit 5766e7e. * Update offline baseline * Add comments & issue links to disabled items * Updates based on PR review comments * Update to document temporary smoke-test removal * Remove standard project Going forward the repo will only be used for servicing. * Update runtime dependency name Co-authored-by: Omair Majid <omajid@redhat.com>
MichaelSimons
pushed a commit
to dotnet/source-build-externals
that referenced
this issue
Feb 8, 2022
* Update arcade and standard shas * Add runtime repo and remove coreclr, corefx and core-setup * Update standard to build with new arcade version * Update version of roslyn to work with updated Arcade * Update patches to enable runtime repo to build * Update aspnet-extensions commit and get it building * Add runtime portable build * Add OverrideTargetRid for Linux * Retain portable logs when cleaning up after portable build * Include project.assets.json files in files to be saved from portable build * Update version of source-build archive * Remove old corefx, coreclr and core-setup projects and update known-good * Add patch for ilasm round trip issue * Add patch for ilasm round trip issue * Update commit shas for repos in known good for preview 2 * Reconcile patches for core-sdk * Reconcile patches for linkere * Reconcile patches for fsharp repo * Reconcile patches for nuget-client repo * Reconcile patches for roslyn repo * Reconcile patches for runtime repo * Reconcile patches for sdk repo * Remove dependency flow sources -- update Arcade version * Update commit sha for standard * Update Arcade and SDK versions * Reconcile patches for arcade repo * Remove ArcadeConfigurationOverride * Fixup output placement for standard repo * Remove unneccessary roslyn patch * Correct invalid merge * Remove linker reflection heuristics patch per comment from sbomer on dotnet/source-build#777 * Update PackagesOutput for linker * Add patch to set nopgooptimize in coreclr build * Update coreclr build arguments * Only build through coreclr for now * Only build through runtime * Add CentOS 8 CI build (#1539) * Add CentOS 8 CI build We have had some issues building in RHEL 8, so lets set up a CentOS 8 CI system to try and catch those issues earlier. * Pin to artifacts version with executable coreclr bits Co-authored-by: Aditya Aggarwal <aditya.aggarwal@microsoft.com> Conflicts: eng/Versions.props repos/coreclr.common.props * Update docker images * Update version of xliff tasks * Include 1 addtional arcade patch * Add patch to exclude Helix tests from source-build in arcade * Add reference to PlatformAbstractions * Skip prebuilt check for now * Update version of previously source-built archive * Update online prebuilt baseline * Disable smoke-tests and unit tests until core-sdk build works * Don't remove placeholder pdb files * Add back temporary ildasm workaround until AspNetCore builds * Update baseline with OSX only prebuilts * Update offline baseline * Turn off processing of smoke-test-packages * Update debian & ubuntu images and turn off leak detection * Update Centos8 docker image to one that includes updated cmake * Another try at updating the centos8 docker image * Update to latest version of Private.SourceBuild.ReferencePackages * Remove detection of and de-assemble/re-assemble of read only ref pkgs With the completion of dotnet/source-build#1497, the need to detect and remove these read only ref packages has been removed. All packages that we have identified as read-only in the past have been included in source-build-reference-packages. If any new ones show up, they will show up as prebuilts and can be added to the source-build-reference-packages repo. * Revert "Skip prebuilt check for now" This reverts commit 5766e7ec6cb245c3348377700ccb3bddda1bf90a. * Update offline baseline * Add comments & issue links to disabled items * Updates based on PR review comments * Update to document temporary smoke-test removal * Remove standard project Going forward the repo will only be used for servicing. * Update runtime dependency name Co-authored-by: Omair Majid <omajid@redhat.com>
|
[Triage] Closing - All linker patches have been eliminated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are a few ways like these that would make the patch go away:
The text was updated successfully, but these errors were encountered: