Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add project(s) to a solution directory #2274

Closed
peterbomers opened this issue Feb 14, 2020 · 1 comment · Fixed by #2551
Closed

[feature] Add project(s) to a solution directory #2274

peterbomers opened this issue Feb 14, 2020 · 1 comment · Fixed by #2551
Labels
feature The issue defines new feature. size:3.0 triaged The issue was evaluated by the triage team, placed on correct area, next action defined.

Comments

@peterbomers
Copy link

The post action Add project(s) to a solution file with id D396686C-DE0E-4DE6-906D-291CD29FC5DE allows us to add projects to an existing solution.

It's however not possible to add a project to a solution folder inside the existing solution.
The dotnet cmd used by the template engine supports this by adding the --solution-folder argument.

It would be nice if could specify it like this:

  "postActions": [
    {
      "description": "Add projects to solution",
      "manualInstructions": [],
      "primaryOutputIndexes": "0",
      "solutionDirectory":  "unit-tests",
      "actionId": "D396686C-DE0E-4DE6-906D-291CD29FC5DE",
      "continueOnError": true
    }
  ]
@donJoseLuis donJoseLuis added needsprioritization triaged The issue was evaluated by the triage team, placed on correct area, next action defined. need-discussion Requires internal discussion prior to answering in an issue. size:3.0 and removed needs-prioritization labels Mar 20, 2020
@donJoseLuis donJoseLuis removed the P1 label Mar 25, 2020
@vlada-shubina vlada-shubina removed the need-discussion Requires internal discussion prior to answering in an issue. label Sep 14, 2020
vlada-shubina added a commit to vlada-shubina/templating that referenced this issue Sep 24, 2020
…ctory for "add projects to a solution" post action
@vlada-shubina vlada-shubina added the feature The issue defines new feature. label Sep 25, 2020
vlada-shubina added a commit to vlada-shubina/templating that referenced this issue Sep 28, 2020
…ctory for "add projects to a solution" post action
@AR-May AR-May added the need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases label Oct 6, 2020
vlada-shubina added a commit to vlada-shubina/templating that referenced this issue Oct 8, 2020
…ctory for "add projects to a solution" post action
@vlada-shubina vlada-shubina removed the need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases label Oct 19, 2020
vlada-shubina added a commit to vlada-shubina/templating that referenced this issue Oct 19, 2020
…ctory for "add projects to a solution" post action
vlada-shubina added a commit that referenced this issue Oct 19, 2020
…post action (#2551)

* fixes #2274: adds possibility to add project to a solution directory for "add projects to a solution" post action
@vlada-shubina vlada-shubina removed their assignment Oct 19, 2020
@vlada-shubina
Copy link
Member

The feature is implemented, JSON schema and documentation is updated

vlada-shubina added a commit to vlada-shubina/templating that referenced this issue Dec 18, 2020
…post action (dotnet#2551)

* fixes dotnet#2274: adds possibility to add project to a solution directory for "add projects to a solution" post action
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jun 7, 2022
…post action (dotnet#2551)

* fixes dotnet/templating#2274: adds possibility to add project to a solution directory for "add projects to a solution" post action
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jul 11, 2022
…post action (dotnet#2551)

* fixes dotnet/templating#2274: adds possibility to add project to a solution directory for "add projects to a solution" post action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature The issue defines new feature. size:3.0 triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Projects
None yet
4 participants