Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add project to a solution directory for "add projects to a solution" post action #2551

Conversation

vlada-shubina
Copy link
Member

fixes #2274: adds possibility to add project to a solution directory for "add projects to a solution" post action

@vlada-shubina vlada-shubina requested a review from a team as a code owner September 24, 2020 14:04
@vlada-shubina vlada-shubina self-assigned this Sep 24, 2020
@vlada-shubina vlada-shubina marked this pull request as draft September 24, 2020 14:04
@vlada-shubina
Copy link
Member Author

Reason for draft: JSON schema should be also updated for this feature, need to find a way how to manage it.

@vlada-shubina vlada-shubina force-pushed the add-folder-option-for-add-to-solution branch from 507c365 to f2d9e1d Compare September 28, 2020 08:15
@vlada-shubina vlada-shubina marked this pull request as ready for review September 28, 2020 08:16
@AR-May AR-May added the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label Oct 5, 2020
Copy link
Contributor

@donJoseLuis donJoseLuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

@vlada-shubina vlada-shubina force-pushed the add-folder-option-for-add-to-solution branch from 34a103b to 686dbfa Compare October 8, 2020 12:57
@vlada-shubina vlada-shubina added the need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases label Oct 8, 2020
@vlada-shubina vlada-shubina removed the need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases label Oct 15, 2020
@vlada-shubina vlada-shubina changed the title add project to a solution directory for "add projects to a solution" post action [doc review pending] add project to a solution directory for "add projects to a solution" post action Oct 15, 2020
@vlada-shubina vlada-shubina force-pushed the add-folder-option-for-add-to-solution branch from 7c9aa37 to f2aab67 Compare October 19, 2020 12:17
@vlada-shubina vlada-shubina changed the title [doc review pending] add project to a solution directory for "add projects to a solution" post action add project to a solution directory for "add projects to a solution" post action Oct 19, 2020
@vlada-shubina vlada-shubina merged commit 4d1bb3a into dotnet:master Oct 19, 2020
@vlada-shubina vlada-shubina deleted the add-folder-option-for-add-to-solution branch October 19, 2020 12:25
vlada-shubina added a commit to vlada-shubina/templating that referenced this pull request Dec 18, 2020
…post action (dotnet#2551)

* fixes dotnet#2274: adds possibility to add project to a solution directory for "add projects to a solution" post action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add project(s) to a solution directory
4 participants