-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add project to a solution directory for "add projects to a solution" post action #2551
Merged
vlada-shubina
merged 4 commits into
dotnet:master
from
vlada-shubina:add-folder-option-for-add-to-solution
Oct 19, 2020
Merged
add project to a solution directory for "add projects to a solution" post action #2551
vlada-shubina
merged 4 commits into
dotnet:master
from
vlada-shubina:add-folder-option-for-add-to-solution
Oct 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for draft: JSON schema should be also updated for this feature, need to find a way how to manage it. |
507c365
to
f2d9e1d
Compare
genalt
approved these changes
Sep 30, 2020
donJoseLuis
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddProjectsToSolutionPostAction.cs
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddProjectsToSolutionPostAction.cs
Outdated
Show resolved
Hide resolved
34a103b
to
686dbfa
Compare
vlada-shubina
commented
Oct 8, 2020
…ctory for "add projects to a solution" post action
added test case
7c9aa37
to
f2aab67
Compare
vlada-shubina
added a commit
to vlada-shubina/templating
that referenced
this pull request
Dec 18, 2020
…post action (dotnet#2551) * fixes dotnet#2274: adds possibility to add project to a solution directory for "add projects to a solution" post action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
triaged
The issue was evaluated by the triage team, placed on correct area, next action defined.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2274: adds possibility to add project to a solution directory for "add projects to a solution" post action