Create shared CsWin32 with System.Drawing.Common #10525
Conversation
This is a rough prototype of a shared interop with System.Drawing.Common. It introduces a new base assembly for shared CsWin32 and other low-level support code. Converted HGLOBAL, DEVMODE and related stuff to the new shared pattern. Also used the CsWin32 generated GdiplusStartup. I have almost no idea if packaging is correct here. Assuming it isn't. `crefs` don't work right when there is overlap in internals. dotnet#10524 tracks this, and this change disables the relevant warnings. I've only smoke tested this with the WinFormsControlsTest.
ghost
assigned 
|
Note that I'm also hitting some weird file locking during builds. This is not necessarily the way we'll go. There are definitely benefits in simpler sharing of low-level code, but we still need to discuss options. Mostly out for the holidays so unlikely to respond to anything until I'm back. |
src/System.Windows.Primitives/src/System.Windows.Primitives.csproj
Outdated
Show resolved
Hide resolved
| XML cref tags don't resolve the same way code does. Until we can get this resolved we need to turn this off in | ||
| order to use CsWin32 in both System.Drawing and System.Windows.Forms. | ||
| --> | ||
| <NoWarn>$(NoWarn);CS1574;CS1580</NoWarn> |
There was a problem hiding this comment.
❓ Are you able to work around this issue using the approach described here?
#10320 (comment)
There was a problem hiding this comment.
Can't specify the root namespace for CsWin32 currently.
There was a problem hiding this comment.
I believe you may have misunderstood my comment. My proposed solution is only relevant for cases where you cannot specify the root namespace.
There was a problem hiding this comment.
My proposed solution is only relevant for cases where you cannot specify the root namespace.
@sharwell that is every case afaik
| IntPtr modeHandle = _printerSettings.GetHdevmode(); | ||
| IntPtr modePointer = Kernel32.GlobalLock(new HandleRef(this, modeHandle)); | ||
| Gdi32.DEVMODE mode = Marshal.PtrToStructure<Gdi32.DEVMODE>(modePointer)!; | ||
| HGLOBAL modeHandle = (HGLOBAL)_printerSettings.GetHdevmode(); |
There was a problem hiding this comment.
seems like we are freeing this a lot. May want to consider adding a scope in the future 🤔
There was a problem hiding this comment.
Definitely intend to :)
JeremyKuhne
changed the title
| public Form1() | ||
| { | ||
| InitializeComponent(); | ||
|
|
||
| _textBox = new RichTextBox |
There was a problem hiding this comment.
@JeremyKuhne - please remove the content, we all use this project for random stuff, it's purpose was to stay empty for easy testing.
This is a rough prototype of a shared interop with System.Drawing.Common. It introduces a new base assembly for shared CsWin32 and other low-level support code.
Converted HGLOBAL, DEVMODE and related stuff to the new shared pattern. Also used the CsWin32 generated GdiplusStartup.
I have almost no idea if packaging is correct here. Assuming it isn't.
crefsdon't work right when there is overlap in internals. #10524 tracks this, and this change disables the relevant warnings.I've only smoke tested this with the WinFormsControlsTest.
Microsoft Reviewers: Open in CodeFlow