Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 4 Deprecation Warning - Fixnum #61

Closed
randallreedjr opened this issue Jun 30, 2018 · 0 comments · Fixed by #62
Closed

Ruby 4 Deprecation Warning - Fixnum #61

randallreedjr opened this issue Jun 30, 2018 · 0 comments · Fixed by #62

Comments

@randallreedjr
Copy link

Upgraded to Ruby 2.5.1, seeing this deprecation warning

/Users/randallreedjr/.rvm/gems/ruby-2.5.1@screenslate/gems/acts_as_indexed-0.8.3/lib/acts_as_indexed/class_methods.rb:177: warning: constant ::Fixnum is deprecated

As of Ruby 2.4.0, Fixnum and Bignum are unified into Integer.
yez pushed a commit to yez/acts_as_indexed that referenced this issue Oct 3, 2018
Change Fixnum test to Integer
84d4df0 
Fixes dougal#61

When updating to Ruby 2.5, Fixnum has been deprecated and eventually
removed.

I also suggest outside of this PR to add more versions to .travis.yml
@yez yez mentioned this issue Oct 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Fixnum test to Integer yez/acts_as_indexed
1 participant
@randallreedjr