Change Fixnum test to Integer #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dougal#61 When updating to Ruby 2.5, Fixnum has been deprecated and eventually removed. I also suggest outside of this PR to add more versions to .travis.yml
|
Build failures seem unrelated to this change. |
|
@yez Thanks for the fix! |
|
@randallreedjr happy to contribute. I'm not able to restart that Travis build so let me know if these failures are legitimate and I can help more. |
Changing a newline to get workflow to run again.
|
Going to merge this next week, trying to see if I can get the workflow working and test this again before merging, but the change seems trivial. |
|
Update: Going to merge after I merge my test-workflow branch to get testing and Github actions going. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
When updating to Ruby 2.5, Fixnum has been deprecated and eventually
removed.
Some formatting was also off and I fixed that.
I also suggest outside of this PR to add more versions to .travis.yml