-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snyk] Upgrade svgo from 3.2.0 to 3.3.2 #5
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade svgo from 3.2.0 to 3.3.2. See this package in npm: svgo See this project in Snyk: https://app.snyk.io/org/dougmendes/project/0c5e460a-42f2-4c7c-a595-90eb390a7160?utm_source=github&utm_medium=referral&page=upgrade-pr
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This PR was automatically created by Snyk using the credentials of a real user.
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to upgrade svgo from 3.2.0 to 3.3.2.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 3 versions ahead of your current version.
The recommended version was released on 22 days ago.
Release notes
Package name: svgo
Notice
An update on what happened with v3.3.0 and v3.3.1. While we have retained CJS support, the migration to EMS has changed the acceptable ways to import SVGO, in ways that users depended on before. This effectively made SVGO v3 a breaking change.
Rather than resolve or workaround these differences, we've opted to release SVGO v3.3.2, which is effectively a revert to v3.2.0, and deprecate versions v3.3.0 and v3.3.1. We'll then proceed to work on releasing v4 which will document the breaking changes, and feature further breaking changes that were slated for v4, like disabling
removeViewBox
by default.Before the v4.0.0 release, I'll put more focus on testing and use release candidates, just to help make the release go smoothly! 👍🏽
Sorry for the headache, and thanks for your patience.
Notice
SVGO v3.3.0, which was meant to migrate to ESM without breaking CJS support, unfortunately broke CJS projects. There was a mistake with exports, so the
loadConfig
function wasn't available in the CJS bundle and lead to issues for many users.Thanks to everyone who raised the issue, and to @ nuintun who submitted a pull request to resolve it so quickly.
I apologize for letting that breaking change through, and will aim to do better. Namely, by adding more tests to cover our exports, and any other public interface in general for each distribution of SVGO, so this doesn't happen again.
SVGO v3.3.1 should resolve the issue for CJS projects, but if you encounter anything else, do let us know by opening an issue on GitHub.
Deprecated
This release introduced breaking changes, which have been reverted in v3.3.2. The bug fixes will be reintroduced in v4.0.0.
What's Changed
ESM
SVGO is now a dual package, serving for both Common JS and ESM usage. We believe there shouldn't be any problems, especially as SVGO as largely stateless, but feel free to open an issue if you encounter problems with this.
To be explicit, this is not a breaking change, and SVGO should continue to work in Common JS projects!
Thanks to @ jdufresne for doing the bulk of the work.
Default Behavior
convertCase
tofalse
.Bug Fixes
filter
attribute. By @ johnkenny54 in #1933path[opacity=0]
as a non-rendering node. By @ johnkenny54 in #1948-o
argument) ends with a trailing slash to a location that didn't exist. By @ SethFalco in #1954SVG Optimization
Metrics
Before and after using vectors from various sources, with the default preset of each respective version:
Before and after of the browser bundle of each respective version:
What's Changed
Bug Fixes
q
was incorrectly converted tot
. By @ KTibow in #1889SVG Optimization
smartArcRounding
tofalse
. By @ KTibow in #1873convertToQ
tofalse
. By @ KTibow in #1889Performance
#stringifyPathData
for performance. By @ SethFalco in #1900Set
instead ofArray
for faster lookups. By @ SethFalco in #1899Metrics
Before and after using vectors from various sources, with the default preset of each respective version:
Before and after of the browser bundle of each respective version:
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: