-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: collapseGroups does not move attributes atomically #1930
Conversation
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
<defs> | ||
<linearGradient xlink:href="#a" id="c" x1="3.97" x2="3.97" y1=".348" y2="4.34" gradientUnits="userSpaceOnUse"/> | ||
</defs> | ||
<filter id="b"> | ||
<feGaussianBlur stdDeviation="1"/> | ||
</filter> | ||
<symbol viewBox="-9.5 -7 19 14"> | ||
<g style="filter:url(#b)"> | ||
<linearGradient id="a" x1="3.97" x2="3.97" y1="2.425" y2="7.55" gradientUnits="userSpaceOnUse"> | ||
<stop offset="1" style="stop-color:#fff"/> | ||
</linearGradient> | ||
</g> | ||
</symbol> | ||
<g transform="matrix(0 -1.2285 -1.2285 0 112.337 268.327)" style="filter:url(#b)"> | ||
<path d="M.84.348H7.1V5.8H3.344z" style="fill:url(#c)"/> | ||
</g> | ||
</svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I somewhat-strongly dislike this test case. It doesn't render in your browser, and it has too much cruft. Use something like this as the input instead.
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | |
<defs> | |
<linearGradient xlink:href="#a" id="c" x1="3.97" x2="3.97" y1=".348" y2="4.34" gradientUnits="userSpaceOnUse"/> | |
</defs> | |
<filter id="b"> | |
<feGaussianBlur stdDeviation="1"/> | |
</filter> | |
<symbol viewBox="-9.5 -7 19 14"> | |
<g style="filter:url(#b)"> | |
<linearGradient id="a" x1="3.97" x2="3.97" y1="2.425" y2="7.55" gradientUnits="userSpaceOnUse"> | |
<stop offset="1" style="stop-color:#fff"/> | |
</linearGradient> | |
</g> | |
</symbol> | |
<g transform="matrix(0 -1.2285 -1.2285 0 112.337 268.327)" style="filter:url(#b)"> | |
<path d="M.84.348H7.1V5.8H3.344z" style="fill:url(#c)"/> | |
</g> | |
</svg> | |
<svg xmlns="http://www.w3.org/2000/svg" width="60" height="60"> | |
<defs> | |
<filter id="a"> | |
<feGaussianBlur stdDeviation="1"/> | |
</filter> | |
</defs> | |
<g transform="scale(2)" style="filter:url(#a)"> | |
<rect width="20" height="20" fill="blue" style=""/> | |
</g> | |
</svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep it as is. The test file is a distillation of the Oxygen icon that was failing. It took me a really long time to isolate the problem, and I know for sure that the original file I submitted was failing before the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I hope you will consider at least making it render in a browser and ideally distill it more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified the test case. New test case fails on main branch, passes here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "incorrect" behavior renders the same as the "correct" behavior, but for the purposes of demonstrating the required behavior this test works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it's pretty hard to build an example where the bug really makes a difference. That's one of the reasons it was so hard to track down. And also why the regression tests with "real" SVGs are important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 88 88">
<filter id="a">
<feGaussianBlur stdDeviation="1"/>
</filter>
<g transform="matrix(0.6,0,0,0.6,20,66)" style="filter:url(#a)">
<path d="M33-83L-10-36L-10-32" style="fill-opacity:1"/>
</g>
</svg>
Here is an example that reproduces the problem and clearly demonstrates the change in rendering caused by the plugin.
It looks like what you describe to be the issue and solution is correct and applies to this example. Could you use this for the test case though, please!
I wonder if we should merge styles in the case that the overlapping attribute is style
. Would need to investigate which styles get priority, but we can tackle that later. 🤔
PS: The method I took to isolate the problem was:
- Rename
regression-fixtures
to.regression-fixtures
to ignore it. - Create a new
regression-fixtures
. - Copy over one of the failing tests, I took
go-home.svg
. - Delete half the SVG at a time until I find which node was causing the mismatch. (Running
node test/regression
between iterations.) - Strip down the SVG until I've made it as small as I can while still getting a mismatch.
- Review in a browser that the rendering was actually impacting, i.e. not just antialiasing.
Later, let's make an argument we can pass to test/regression.js
to only test a specific file. Then it'll be easier to do this kind of thing to debug a specific mismatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the test file.
I did pretty much what you did to isolate this, but this one was difficult to isolate because the file didn't fail if you only ran collapseGroups - you also had to run some other combination of plugins that would reorder the attributes in a way that would cause collapseGroups to trigger the error, and deleting parts of the original file sometimes changed things in such a way that the error didn't show up, so there were a lot of red herrings.
Also, see PR #1932 - this is a start on changing regression.js to make testing/analysis easier. I've been using this version to analyze problems and test changes. Still more to be done obviously, but it's a start.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [svgo](https://svgo.dev) ([source](https://github.com/svg/svgo)) | [`3.2.0` -> `3.3.2`](https://renovatebot.com/diffs/npm/svgo/3.2.0/3.3.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/svgo/3.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/svgo/3.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/svgo/3.2.0/3.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/svgo/3.2.0/3.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>svg/svgo (svgo)</summary> ### [`v3.3.2`](https://github.com/svg/svgo/releases/tag/v3.3.2) [Compare Source](https://github.com/svg/svgo/compare/v3.3.1...v3.3.2) ##### Notice An update on what happened with v3.3.0 and v3.3.1. While we have retained CJS support, the migration to EMS has changed the acceptable ways to import SVGO, in ways that users depended on before. This effectively made SVGO v3 a breaking change. Rather than resolve or workaround these differences, we've opted to release SVGO v3.3.2, which is effectively a revert to v3.2.0, and deprecate versions v3.3.0 and v3.3.1. We'll then proceed to work on releasing v4 which will document the breaking changes, and feature further breaking changes that were slated for v4, like disabling `removeViewBox` by default. Before the v4.0.0 release, I'll put more focus on testing and use release candidates, just to help make the release go smoothly! 👍🏽 Sorry for the headache, and thanks for your patience. ### [`v3.3.1`](https://github.com/svg/svgo/releases/tag/v3.3.1) [Compare Source](https://github.com/svg/svgo/compare/v3.3.0...v3.3.1) ##### Notice SVGO v3.3.0, which was meant to migrate to ESM without breaking CJS support, unfortunately broke CJS projects. There was a mistake with exports, so the `loadConfig` function wasn't available in the CJS bundle and lead to issues for many users. Thanks to everyone who raised the issue, and to [@​nuintun](https://github.com/nuintun) who submitted a pull request to resolve it so quickly. I apologize for letting that breaking change through, and will aim to do better. Namely, by adding more tests to cover our exports, and any other public interface in general for each distribution of SVGO, so this doesn't happen again. SVGO v3.3.1 should resolve the issue for CJS projects, but if you encounter anything else, do let us know by opening an issue on GitHub. ### [`v3.3.0`](https://github.com/svg/svgo/releases/tag/v3.3.0) [Compare Source](https://github.com/svg/svgo/compare/v3.2.0...v3.3.0) ##### Deprecated This release introduced breaking changes, which have been reverted in v3.3.2. The bug fixes will be reintroduced in v4.0.0. ##### What's Changed ##### ESM SVGO is now a dual package, serving for both Common JS and ESM usage. We believe there shouldn't be any problems, especially as SVGO as largely stateless, but feel free to open an issue if you encounter problems with this. To be explicit, this is not a breaking change, and SVGO should continue to work in Common JS projects! Thanks to [@​jdufresne](https://github.com/jdufresne) for doing the bulk of the work. ##### Default Behavior - [`convertColors`](), now converts all references to colors excluding references to IDs to lowercase. This can be disabled by setting `convertCase` to `false`. ##### Bug Fixes - [`cleanupIds`](), treat both URI encoded and non-URI encoded IDs as the same. By [@​liuweifeng](https://github.com/liuweifeng) in [#​1982](https://github.com/svg/svgo/issues/1982) - [`collapseGroups`](), check styles as well as attributes. By [@​johnkenny54](https://github.com/johnkenny54) in [#​1952](https://github.com/svg/svgo/issues/1952) - [`collapseGroups`](), move attributes atomically. By [@​johnkenny54](https://github.com/johnkenny54) in [https://github.com/svg/svgo/pull/1930](https://github.com/svg/svgo/pull/1930) - [`convertPathData`](), fix q control point when item is removed. By [@​KTibow](https://github.com/KTibow) in [https://github.com/svg/svgo/pull/1927](https://github.com/svg/svgo/pull/1927) - [`convertPathData`](), preserve vertex for markers only paths. By [@​SethFalco](https://github.com/SethFalco) in [#​1967](https://github.com/svg/svgo/issues/1967) - [`mergePaths`](), don't merge paths if attributes/styles depend depend on the nodes bounding box. By [@​johnkenny54](https://github.com/johnkenny54) in [#​1964](https://github.com/svg/svgo/issues/1964) - [`moveElemsAttrsToGroups`](), no longer moves the transforms if group has the `filter` attribute. By [@​johnkenny54](https://github.com/johnkenny54) in [#​1933](https://github.com/svg/svgo/issues/1933) - [`prefixIds`](), fixed issue where some IDs were not prefixed when style tag contained XML comments. By [@​john-neptune](https://github.com/john-neptune) in [#​1942](https://github.com/svg/svgo/issues/1942) - [`removeHiddenElems`](), don't remove node if child element has a referenced ID. By [@​johnkenny54](https://github.com/johnkenny54) in [https://github.com/svg/svgo/pull/1925](https://github.com/svg/svgo/pull/1925) - [`removeHiddenElems`](), treat `path[opacity=0]` as a non-rendering node. By [@​johnkenny54](https://github.com/johnkenny54) in [#​1948](https://github.com/svg/svgo/issues/1948) - [`removeUselessDefs`](https://svgo.dev/docs/plugins/remove-useless-defs/), don't remove node if child element has an ID. By [@​johnkenny54](https://github.com/johnkenny54) in [https://github.com/svg/svgo/pull/1923](https://github.com/svg/svgo/pull/1923) - When stringifying path data, include a space before numbers represented in scientific notation. By [@​johnkenny54](https://github.com/johnkenny54) in [#​1961](https://github.com/svg/svgo/issues/1961) - No longer crashes when the output (`-o` argument) ends with a trailing slash to a location that didn't exist. By [@​SethFalco](https://github.com/SethFalco) in [#​1954](https://github.com/svg/svgo/issues/1954) ##### SVG Optimization - [`convertColors`](), introduce parameter to convert colors to common casing (lowercase/uppercase). By [@​JayLeininger](https://github.com/JayLeininger) in [https://github.com/svg/svgo/pull/1692](https://github.com/svg/svgo/pull/1692) - [`removeDeprecatedAttrs`](), new plugin that is disabled by default to remove SVG attributes that are deprecated. By [@​jdufresne](https://github.com/jdufresne) in [#​1869](https://github.com/svg/svgo/issues/1869) ##### Metrics Before and after using vectors from various sources, with the default preset of each respective version: | SVG | Original | v3.2.0 | v3.3.0 | Delta | |---|---|---|---|---| | [Arch Linux Logo](https://archlinux.org/art/) | 9.529 KiB | 4.115 KiB | 4.097 KiB | ⬇️ 0.018 KiB | | [Blobs](https://gitlab.gnome.org/GNOME/gnome-backgrounds/-/blob/main/backgrounds/blobs-d.svg) | 50.45 KiB | 42.623 KiB | 42.609 KiB | ⬇️ 0.014 KiB | | [Isometric Madness](https://inkscape.org/~Denis_Kuznetsky/%E2%98%85isometric-madness) | 869.034 KiB | 540.582 KiB | 540.073 KiB | ⬇️ 0.509 KiB | | [tldr-pages Banner](https://github.com/tldr-pages/tldr/blob/main/images/banner.svg) | 2.071 KiB | 1.07 KiB | 1.07 KiB | | | [Wikipedia Logo](https://en.wikipedia.org/wiki/File:Wikipedia-logo-v2.svg) | 161.551 KiB | 111.668 KiB | 111.668 KiB | | Before and after of the browser bundle of each respective version: | | v3.2.0 | v3.3.0 | Delta | |---|---|---|---| | svgo.browser.js | 910.9 kB | 753.0 kB | ⬇️ 157.9 kB | </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cozy/cozy-stack). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [svgo](https://svgo.dev) ([source](https://github.com/svg/svgo)) | [`3.2.0` -> `3.3.2`](https://renovatebot.com/diffs/npm/svgo/3.2.0/3.3.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/svgo/3.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/svgo/3.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/svgo/3.2.0/3.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/svgo/3.2.0/3.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>svg/svgo (svgo)</summary> ### [`v3.3.2`](https://github.com/svg/svgo/releases/tag/v3.3.2) [Compare Source](https://github.com/svg/svgo/compare/v3.3.1...v3.3.2) #### Notice An update on what happened with v3.3.0 and v3.3.1. While we have retained CJS support, the migration to EMS has changed the acceptable ways to import SVGO, in ways that users depended on before. This effectively made SVGO v3 a breaking change. Rather than resolve or workaround these differences, we've opted to release SVGO v3.3.2, which is effectively a revert to v3.2.0, and deprecate versions v3.3.0 and v3.3.1. We'll then proceed to work on releasing v4 which will document the breaking changes, and feature further breaking changes that were slated for v4, like disabling `removeViewBox` by default. Before the v4.0.0 release, I'll put more focus on testing and use release candidates, just to help make the release go smoothly! 👍🏽 Sorry for the headache, and thanks for your patience. ### [`v3.3.1`](https://github.com/svg/svgo/releases/tag/v3.3.1) [Compare Source](https://github.com/svg/svgo/compare/v3.3.0...v3.3.1) #### Notice SVGO v3.3.0, which was meant to migrate to ESM without breaking CJS support, unfortunately broke CJS projects. There was a mistake with exports, so the `loadConfig` function wasn't available in the CJS bundle and lead to issues for many users. Thanks to everyone who raised the issue, and to [@​nuintun](https://github.com/nuintun) who submitted a pull request to resolve it so quickly. I apologize for letting that breaking change through, and will aim to do better. Namely, by adding more tests to cover our exports, and any other public interface in general for each distribution of SVGO, so this doesn't happen again. SVGO v3.3.1 should resolve the issue for CJS projects, but if you encounter anything else, do let us know by opening an issue on GitHub. ### [`v3.3.0`](https://github.com/svg/svgo/releases/tag/v3.3.0) [Compare Source](https://github.com/svg/svgo/compare/v3.2.0...v3.3.0) #### Deprecated This release introduced breaking changes, which have been reverted in v3.3.2. The bug fixes will be reintroduced in v4.0.0. #### What's Changed ##### ESM SVGO is now a dual package, serving for both Common JS and ESM usage. We believe there shouldn't be any problems, especially as SVGO as largely stateless, but feel free to open an issue if you encounter problems with this. To be explicit, this is not a breaking change, and SVGO should continue to work in Common JS projects! Thanks to [@​jdufresne](https://github.com/jdufresne) for doing the bulk of the work. ##### Default Behavior - [`convertColors`](), now converts all references to colors excluding references to IDs to lowercase. This can be disabled by setting `convertCase` to `false`. ##### Bug Fixes - [`cleanupIds`](), treat both URI encoded and non-URI encoded IDs as the same. By [@​liuweifeng](https://github.com/liuweifeng) in [#​1982](https://github.com/svg/svgo/issues/1982) - [`collapseGroups`](), check styles as well as attributes. By [@​johnkenny54](https://github.com/johnkenny54) in [#​1952](https://github.com/svg/svgo/issues/1952) - [`collapseGroups`](), move attributes atomically. By [@​johnkenny54](https://github.com/johnkenny54) in [https://github.com/svg/svgo/pull/1930](https://github.com/svg/svgo/pull/1930) - [`convertPathData`](), fix q control point when item is removed. By [@​KTibow](https://github.com/KTibow) in [https://github.com/svg/svgo/pull/1927](https://github.com/svg/svgo/pull/1927) - [`convertPathData`](), preserve vertex for markers only paths. By [@​SethFalco](https://github.com/SethFalco) in [#​1967](https://github.com/svg/svgo/issues/1967) - [`mergePaths`](), don't merge paths if attributes/styles depend depend on the nodes bounding box. By [@​johnkenny54](https://github.com/johnkenny54) in [#​1964](https://github.com/svg/svgo/issues/1964) - [`moveElemsAttrsToGroups`](), no longer moves the transforms if group has the `filter` attribute. By [@​johnkenny54](https://github.com/johnkenny54) in [#​1933](https://github.com/svg/svgo/issues/1933) - [`prefixIds`](), fixed issue where some IDs were not prefixed when style tag contained XML comments. By [@​john-neptune](https://github.com/john-neptune) in [#​1942](https://github.com/svg/svgo/issues/1942) - [`removeHiddenElems`](), don't remove node if child element has a referenced ID. By [@​johnkenny54](https://github.com/johnkenny54) in [https://github.com/svg/svgo/pull/1925](https://github.com/svg/svgo/pull/1925) - [`removeHiddenElems`](), treat `path[opacity=0]` as a non-rendering node. By [@​johnkenny54](https://github.com/johnkenny54) in [#​1948](https://github.com/svg/svgo/issues/1948) - [`removeUselessDefs`](https://svgo.dev/docs/plugins/remove-useless-defs/), don't remove node if child element has an ID. By [@​johnkenny54](https://github.com/johnkenny54) in [https://github.com/svg/svgo/pull/1923](https://github.com/svg/svgo/pull/1923) - When stringifying path data, include a space before numbers represented in scientific notation. By [@​johnkenny54](https://github.com/johnkenny54) in [#​1961](https://github.com/svg/svgo/issues/1961) - No longer crashes when the output (`-o` argument) ends with a trailing slash to a location that didn't exist. By [@​SethFalco](https://github.com/SethFalco) in [#​1954](https://github.com/svg/svgo/issues/1954) ##### SVG Optimization - [`convertColors`](), introduce parameter to convert colors to common casing (lowercase/uppercase). By [@​JayLeininger](https://github.com/JayLeininger) in [https://github.com/svg/svgo/pull/1692](https://github.com/svg/svgo/pull/1692) - [`removeDeprecatedAttrs`](), new plugin that is disabled by default to remove SVG attributes that are deprecated. By [@​jdufresne](https://github.com/jdufresne) in [#​1869](https://github.com/svg/svgo/issues/1869) #### Metrics Before and after using vectors from various sources, with the default preset of each respective version: | SVG | Original | v3.2.0 | v3.3.0 | Delta | |---|---|---|---|---| | [Arch Linux Logo](https://archlinux.org/art/) | 9.529 KiB | 4.115 KiB | 4.097 KiB | ⬇️ 0.018 KiB | | [Blobs](https://gitlab.gnome.org/GNOME/gnome-backgrounds/-/blob/main/backgrounds/blobs-d.svg) | 50.45 KiB | 42.623 KiB | 42.609 KiB | ⬇️ 0.014 KiB | | [Isometric Madness](https://inkscape.org/~Denis_Kuznetsky/%E2%98%85isometric-madness) | 869.034 KiB | 540.582 KiB | 540.073 KiB | ⬇️ 0.509 KiB | | [tldr-pages Banner](https://github.com/tldr-pages/tldr/blob/main/images/banner.svg) | 2.071 KiB | 1.07 KiB | 1.07 KiB | | | [Wikipedia Logo](https://en.wikipedia.org/wiki/File:Wikipedia-logo-v2.svg) | 161.551 KiB | 111.668 KiB | 111.668 KiB | | Before and after of the browser bundle of each respective version: | | v3.2.0 | v3.3.0 | Delta | |---|---|---|---| | svgo.browser.js | 910.9 kB | 753.0 kB | ⬇️ 157.9 kB | </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on Monday after 10am before 7pm" in timezone Asia/Seoul, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/channel-io/bezier-react). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJjaG9yZTpkZXBzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
In the test case file, before this change, the transform attribute on the group was moved to the child, but the style containing the filter was not moved. This was changing the rendering.
regression.js before fix:
After fix:
This removes 13 regression mismatches. Compression of regression files is reduced by 1039 bytes.
Closes #1928