seed for random generator #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added method for setting seed of random generator
drager
requested changes
Oct 29, 2020
Comment on lines
-155
to
-175
|
|
||
| /// Generates an User Agent from Predefined Dictionary | ||
| /// with the given [osName] if provided. | ||
| /// if not provided [osName] is an empty String or [''] | ||
| /// | ||
| /// Example: | ||
| /// ```dart | ||
| /// faker.internet.userAgent(); | ||
| /// faker.internet.userAgent(osName:'ios'); | ||
| /// ``` | ||
| String userAgent({String osName = ''}) => random | ||
| .element(UserAgents.fromJson(userAgentDatas) | ||
| .userAgents | ||
| .map((e) => e) | ||
| .where( | ||
| (element) => | ||
| element.osName.toLowerCase().contains(osName.toLowerCase()), | ||
| ) | ||
| .toList()) | ||
| .userAgent | ||
| .toString(); |
There was a problem hiding this comment.
Yep. My bad. It seems that I used and older fork of faker, without the userAgent and image commit. Can you omit those changes, or should I make another pull request? Only added a method in random_generator.dart
There was a problem hiding this comment.
Please make a new commit that brings those deletions back if possible.
| @@ -39,7 +37,6 @@ class Faker { | |||
| currency = const Currency(), | |||
| food = const Food(), | |||
| guid = const Guid(), | |||
| image = const Image(), | |||
2 tasks
|
Closing this due to #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method for setting seed of random generator
Connection with issue(s)
Resolve issue #25
Testing and Review Notes
Only tested in Flutter for the web, but should work for all.
To Do