Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Resolve issue #25
Connected to #29
Testing and Review Notes
All previous unit tests should pass and also added a new test for random seeds.
In addition to adding support for seeds I also did some refactoring on the
RandomGenerator
class. In the original implementation allRandomGenerator
instances were using the sameRandom
instance under the hood which meant you couldn't have multipleFaker
instances running on different seeds. In the new implementation eachRandomGenerator
has it's ownRandom
instance and seed.To Do