Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed support for random generator #32

Merged
merged 6 commits into from
Jan 10, 2021
Merged

Conversation

daemon3000
Copy link
Contributor

@daemon3000 daemon3000 commented Dec 13, 2020

Connection with issue(s)

Resolve issue #25

Connected to #29

Testing and Review Notes

All previous unit tests should pass and also added a new test for random seeds.

In addition to adding support for seeds I also did some refactoring on the RandomGenerator class. In the original implementation all RandomGenerator instances were using the same Random instance under the hood which meant you couldn't have multiple Faker instances running on different seeds. In the new implementation each RandomGenerator has it's own Random instance and seed.

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers

Copy link
Owner

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants