chore(helm): Make release pipeline to update golden files #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pothulapati
force-pushed
the
tar/release-chart
branch
2 times, most recently
from
408556a to
30dc1b3
Compare
|
Need to update the branch |
Pothulapati
force-pushed
the
tar/release-chart
branch
from
30dc1b3 to
6f3b1bd
Compare
Golden files need to be updated as version is updated in the
`Chart.yaml` file. This commit adds the step to update the golden
files in the release pipeline.
To make that possible, The following additional changes are also
required:
- `Go.Work`: This adds support multi-module projects as we will
have the tests along with the operator in sub-folders. This
is required to run go cmds from the root directory. (like
running tests in this case).
- `.helmignore`: This updates the Helm chart to ignore the `/ci`
folder during helm packaging as those are not required for
users of the chart.
Pothulapati
force-pushed
the
tar/release-chart
branch
from
6f3b1bd to
79fa3e1
Compare
|
@ashotland Updated! |
ashotland
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golden files need to be updated as version is updated in the
Chart.yamlfile. This commit adds the step to update the golden files in the release pipeline.To make that possible, The following additional changes are also required:
Go.Work: This adds support multi-module workspaces as we will have the tests along with the operator in sub-folders. This is required to run go cmds from the root directory. (like running tests in this case)..helmignore: This updates the Helm chart to ignore the/cifolder during helm packaging as those are not required for users of the chart.