Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some inspection results #5

Merged
merged 10 commits into from
Sep 15, 2017
Merged

Fixed some inspection results #5

merged 10 commits into from
Sep 15, 2017

Conversation

drakeet
Copy link
Owner

@drakeet drakeet commented Sep 15, 2017

Inefficient use of keySet iterator instead of entrySet iterator

@drakeet drakeet changed the title Fixed two Inefficient use of keySet iterator of Floo Fixed all FindBugs issues Sep 15, 2017
@drakeet drakeet changed the title Fixed all FindBugs issues Fixed some inspection results Sep 15, 2017
@drakeet
Copy link
Owner Author

drakeet commented Sep 15, 2017

And in 35e2679, we fixed a bug that stackObserverInitialized is always false.

@drakeet
Copy link
Owner Author

drakeet commented Sep 15, 2017

TODO: Supply some unit tests.

@drakeet drakeet merged commit 5368d02 into master Sep 15, 2017
@drakeet drakeet deleted the findbugs branch September 15, 2017 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant