Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0.0 #780

Merged
merged 12 commits into from
May 8, 2017
Merged

Release 3.0.0 #780

merged 12 commits into from
May 8, 2017

Conversation

codebycliff
Copy link
Collaborator

Contains version bump for release 3.0.0. The changelog could use more details if there are some.

@codebycliff
Copy link
Collaborator Author

Referencing issue here: #777

@codebycliff codebycliff mentioned this pull request Mar 24, 2017
@codebycliff
Copy link
Collaborator Author

Actually, would we want to get some of these breaking changes in before we release a major version?

Rename UninferrableSourceError to UninferrableObjectError
Remove conflicting source alias

@codebycliff codebycliff added this to the 3.0.0 milestone Mar 28, 2017
@syguer
Copy link
Contributor

syguer commented Mar 28, 2017

#768 has compatibility, so it can includes.
I think #725 looks better to fix before upgrade to major version. Because next major version will release after long time 🤔

@codebycliff
Copy link
Collaborator Author

I have added both pull requests to the 3.0.0 milestone. My plan is to track all changes for 3.0.0 within this milestone. If you see something else you feel should make it into the release, please comment here and I'll add it.

As far as
#768, I was thinking about removing the compatibility with it as well and note it as a breaking change. Does anybody see an issue with doing so?

@syguer
Copy link
Contributor

syguer commented Mar 29, 2017

Should we fix this? #773

@codebycliff
Copy link
Collaborator Author

I haven't had a chance to verify it's reproducible. Once it's verified, I'll add it to the 3.0.0 milestone. If you want to take a stab at verifying / fixing it, that would be great. Otherwise, I'll get to it once I get a few more pressing things merged.

@dgmora
Copy link

dgmora commented Apr 27, 2017

Hi guys, thanks a ton for the gem!

I just wanted to ask, will 3.0 be released soon?
We are running draper 3.0.0.pre1, and we wanted to update to rails 5.1, but draper pre1 does not work well with 5.1.

If it still takes some time, maybe a 3.0.0.pre2 would make sense, as the previous one was release in july last year. I know we have the option of using github as the source, but having a release version would in general be better.

Cheers

@codebycliff
Copy link
Collaborator Author

I planned to cut a release here at RailsConf, however, it's looking more like next week. I should have 3.0.0 on RubyGems by the end of next week.

@IvanShamatov
Copy link

IvanShamatov commented May 4, 2017

Sorry for disturbing again, @codebycliff. Are there any issues stops you from making release? Anything I or community can help with? Thank you.

@codebycliff
Copy link
Collaborator Author

@IvanShamatov Nope, no issues. I just wanted to make sure I'd be around after the release to fix issues that may arise. I should have the release out this morning.

@codebycliff codebycliff merged commit 5319530 into drapergem:master May 8, 2017
@codebycliff
Copy link
Collaborator Author

Release 3.0.0 has been pushed to RubyGems 🎉 . Please report any issues you may come across.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants