Never re-raise NameError and always default to CollectionDecorator #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
codebycliff
added a commit
to codebycliff/draper
that referenced
this pull request
Apr 4, 2017
codebycliff
added a commit
that referenced
this pull request
May 8, 2017
* Release 3.0.0 * Add breaking change #768 to changelog. * Add recently merged changes to the changelog. * Add configuration and custom default controller to the changelog. * Add entry to changelog for pull request 720 * Add entry to changelog for Rails 5 API-only support. * Add changelog entry for pull request #795. * Add changelog entry for pull request #796. * Add changelog entry for enumerable optimization. * Update maintainer information in README. * Add pull request #799 to changelog. * Add compatability documentation to readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes it so that
NameErroris never re-raised when callingcollection_decorator_class. This makes it so that it always defaults toDraper::CollectionDecorator. TheNameErrorthat we would be silencing would have been caused by us to begin with. See the original pull request for full detail:minor fix to error raising on collection decoration.
Testing
See the original pull request comments.
To-Dos
None
References