Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sheets)!: separate ui from formula and dv plugin #3527

Merged
merged 25 commits into from
Oct 10, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Sep 22, 2024

Breaking Changes

  1. sheets-formula had been split into two plugins: sheets-formula and sheets-formula-ui. Please import sheets-formula-ui into your front end code as well.
  2. sheets-data-validation had been split into two plugins: sheets-data-validation and sheets-data-validation-ui. Please import sheets-data-validation-ui into your front end code as well. Configuration of sheets-data-validation should be moved to sheets-data-validation-ui as well.

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 22, 2024

Playwright test results

passed  11 passed

Details

stats  11 tests across 5 suites
duration  2 minutes, 50 seconds
commit  28ed7e2
info  For more information, see full report

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 11.19005% with 500 lines in your changes missing coverage. Please review.

Project coverage is 31.12%. Comparing base (7a0b3ed) to head (28ed7e2).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...mula-ui/src/controllers/utils/ref-range-formula.ts 19.82% 186 Missing ⚠️
...alidation-ui/src/views/components/detail/index.tsx 0.00% 97 Missing ⚠️
...-validation-ui/src/controllers/dv-ui.controller.ts 0.00% 22 Missing ⚠️
packages/sheets-formula-ui/src/services/utils.ts 0.00% 22 Missing ⚠️
packages/sheets-data-validation-ui/src/plugin.ts 0.00% 21 Missing ⚠️
.../sheets-formula-ui/src/sheets-formula-ui.plugin.ts 0.00% 21 Missing ⚠️
...rmula/src/controllers/update-formula.controller.ts 0.00% 19 Missing ⚠️
...rc/commands/commands/data-validation-ui.command.ts 0.00% 16 Missing ⚠️
.../src/controllers/trigger-calculation.controller.ts 0.00% 12 Missing ⚠️
...ckages/sheets-formula/src/sheets-formula.plugin.ts 0.00% 10 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3527      +/-   ##
==========================================
- Coverage   31.80%   31.12%   -0.68%     
==========================================
  Files        2225     2250      +25     
  Lines      115648   116201     +553     
  Branches    25462    25570     +108     
==========================================
- Hits        36777    36170     -607     
- Misses      78871    80031    +1160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev marked this pull request as ready for review September 27, 2024 06:13
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge qa:untested This PR is ready to be tested and removed qa:verified This PR has already by verified by a QA and is considered good enough to be merge labels Sep 27, 2024
@univer-bot
Copy link

univer-bot bot commented Sep 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: refactor(sheets-formula)!: separate formula plugin

Title: refactor(sheets-formula)!: separate formula plugin


close #xxx. 验证公式相关的模块

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev changed the title refactor: separate formula plugin refactor(sheets-formula)!: separate formula plugin Sep 27, 2024
@wzhudev wzhudev marked this pull request as draft September 27, 2024 06:22
@wzhudev wzhudev marked this pull request as ready for review October 8, 2024 03:51
@wzhudev wzhudev changed the title refactor(sheets-formula)!: separate formula plugin refactor(sheets)!: separate ui from formula and data-validation plugin Oct 8, 2024
@wzhudev wzhudev changed the title refactor(sheets)!: separate ui from formula and data-validation plugin refactor(sheets)!: separate ui from formula and dv plugin Oct 8, 2024
@wzhudev
Copy link
Member Author

wzhudev commented Oct 8, 2024

/update-snapshots

@wzhudev wzhudev merged commit 9947c22 into dev Oct 10, 2024
9 of 10 checks passed
@wzhudev wzhudev deleted the refactor/computing branch October 10, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants