-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sheets)!: separate ui from formula and dv plugin #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
wzhudev
force-pushed
the
refactor/computing
branch
from
September 22, 2024 13:17
7f896c6
to
33cf18d
Compare
Playwright test resultsDetails 11 tests across 5 suites |
wzhudev
force-pushed
the
refactor/computing
branch
from
September 22, 2024 13:22
33cf18d
to
de26ba7
Compare
wzhudev
requested review from
Dushusir,
jikkai,
VicKun4937,
hexf00,
Jocs and
Gggpound
as code owners
September 27, 2024 06:13
zhaolixin7
added
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
qa:untested
This PR is ready to be tested
and removed
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
labels
Sep 27, 2024
Origin Title: refactor(sheets-formula)!: separate formula plugin Title: refactor(sheets-formula)!: separate formula plugin close #xxx. 验证公式相关的模块 Pull Request Checklist
|
wzhudev
changed the title
refactor: separate formula plugin
refactor(sheets-formula)!: separate formula plugin
Sep 27, 2024
wzhudev
force-pushed
the
refactor/computing
branch
from
October 8, 2024 03:50
4d37f20
to
ef768c8
Compare
wzhudev
requested review from
ybzky,
yuhongz,
weird94 and
lumixraku
as code owners
October 8, 2024 03:51
wzhudev
changed the title
refactor(sheets-formula)!: separate formula plugin
refactor(sheets)!: separate ui from formula and data-validation plugin
Oct 8, 2024
wzhudev
changed the title
refactor(sheets)!: separate ui from formula and data-validation plugin
refactor(sheets)!: separate ui from formula and dv plugin
Oct 8, 2024
/update-snapshots |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
sheets-formula
had been split into two plugins:sheets-formula
andsheets-formula-ui
. Please importsheets-formula-ui
into your front end code as well.sheets-data-validation
had been split into two plugins:sheets-data-validation
andsheets-data-validation-ui
. Please importsheets-data-validation-ui
into your front end code as well. Configuration ofsheets-data-validation
should be moved tosheets-data-validation-ui
as well.Pull Request Checklist