Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove runOnLifecycle and add smoking tests #3672

Merged
merged 16 commits into from
Oct 10, 2024
Merged

refactor: remove runOnLifecycle and add smoking tests #3672

merged 16 commits into from
Oct 10, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 9, 2024

pending #3527

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev marked this pull request as draft October 9, 2024 12:24
Copy link

github-actions bot commented Oct 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 9, 2024

Playwright test results

failed  2 failed
passed  12 passed

Details

stats  14 tests across 8 suites
duration  4 minutes, 21 seconds
commit  2470f91
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff default sheet content
chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff demo sheet content

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 3.46021% with 279 lines in your changes missing coverage. Please review.

Project coverage is 31.06%. Comparing base (16a08bf) to head (a82059f).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ges/sheets-data-validation-ui/src/mobile-plugin.ts 0.00% 29 Missing ⚠️
packages/sheets-ui/src/sheets-ui-plugin.ts 0.00% 15 Missing ⚠️
...ges/sheets-conditional-formatting-ui/src/plugin.ts 0.00% 14 Missing ⚠️
packages/engine-formula/src/plugin.ts 0.00% 13 Missing ⚠️
packages/sheets/src/sheets-plugin.ts 0.00% 13 Missing ⚠️
packages/sheets-hyper-link-ui/src/plugin.ts 0.00% 11 Missing ⚠️
...es/ui/src/controllers/ui/ui-desktop.controller.tsx 0.00% 10 Missing ⚠️
packages/docs-ui/src/docs-ui-plugin.ts 0.00% 9 Missing ⚠️
packages/sheets-data-validation-ui/src/plugin.ts 0.00% 9 Missing ⚠️
...der-controllers/sheet-drawing.render-controller.ts 0.00% 9 Missing ⚠️
... and 43 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3672      +/-   ##
==========================================
- Coverage   31.12%   31.06%   -0.07%     
==========================================
  Files        2250     2250              
  Lines      116219   116374     +155     
  Branches    25573    25581       +8     
==========================================
- Hits        36176    36149      -27     
- Misses      80043    80225     +182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev marked this pull request as ready for review October 10, 2024 11:21
@wzhudev wzhudev changed the title test: add demo smoking tests refactor: remove runOnLifecycle and add smoking tests Oct 10, 2024
@wzhudev wzhudev merged commit f5e97b1 into dev Oct 10, 2024
3 checks passed
@wzhudev wzhudev deleted the ci/smoking branch October 10, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants