build(workflow): same node version on all stages #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roschaefer
force-pushed
the
tool-versions
branch
3 times, most recently
from
7af0f9f to
cdad51a
Compare
roschaefer
commented
Jul 2, 2024
.tool-versions
Outdated
| @@ -0,0 +1 @@ | |||
| nodejs 21.4.0 | |||
There was a problem hiding this comment.
@Elweyn what's the version that we're using in production? On my vagrant machine on alpine 3.19 it's still v18.
There was a problem hiding this comment.
We checked and its also different between production and staging:
Prod: v20.11.1
Stage: v20.12.1
roschaefer
commented
Jul 2, 2024
| @@ -9,13 +9,13 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| env: | |||
| CHROMATIC_PROJECT_TOKEN: ${{ secrets.CHROMATIC_PROJECT_TOKEN_ADMIN }} | |||
| WORKING_DIRECTORY: ./admin | |||
There was a problem hiding this comment.
This is not related to nodejs but there is absolutely no reason why we should pollute process.env and have no benefit of another variable WORKING_DIRECTORY if we're using it only once.
roschaefer
force-pushed
the
tool-versions
branch
3 times, most recently
from
8d8b42e to
2689076
Compare
roschaefer
commented
Jul 2, 2024
roschaefer
force-pushed
the
tool-versions
branch
3 times, most recently
from
bd94773 to
ca3be47
Compare
roschaefer
force-pushed
the
tool-versions
branch
2 times, most recently
from
a678f3c to
2cec036
Compare
roschaefer
commented
Jul 4, 2024
| @@ -87,7 +87,7 @@ | |||
| "#types/*": "./src/graphql/types/*" | |||
| }, | |||
| "engines": { | |||
| "node": ">=21" | |||
| "node": ">=20" | |||
There was a problem hiding this comment.
That one is important for eslint.
roschaefer
commented
Jul 4, 2024
| "typescript": "^5.5.2" | ||
| }, | ||
| "engines": { | ||
| "node": ">=21" |
There was a problem hiding this comment.
That one was obsolete.
roschaefer
force-pushed
the
tool-versions
branch
2 times, most recently
from
bafb1a3 to
70d993d
Compare
roschaefer
commented
Jul 4, 2024
| "devDependencies": { | ||
| "@vuepress/bundler-vite": "^2.0.0-rc.11", | ||
| "@vuepress/theme-default": "^2.0.0-rc.35", |
There was a problem hiding this comment.
Unrelated, missing from #1325
Mogge
requested changes
Jul 8, 2024
No, it is completely up to the developer what they use. As written in the README just make sure that you use the node version specified in We just have to save the version in some file. Workflows shall take this file as a reference. Good? |
roschaefer
force-pushed
the
tool-versions
branch
2 times, most recently
from
dc736ec to
6854a5b
Compare
roschaefer
added a commit
that referenced
this pull request
Jul 8, 2024
Motivation ---------- These volumes are not in use, let's remove them. As the comment says, the original intention was to have a different node version in the container and the host. This is something that we *don't* want. We want to use the same node version *always*, see #1319. How to test ----------- 1. Nothing to test, disabled code.
roschaefer
added a commit
that referenced
this pull request
Jul 9, 2024
Motivation ---------- These volumes are not in use, let's remove them. As the comment says, the original intention was to have a different node version in the container and the host. This is something that we *don't* want. We want to use the same node version *always*, see #1319. How to test ----------- 1. Nothing to test, disabled code.
roschaefer
added a commit
that referenced
this pull request
Jul 9, 2024
Motivation ---------- These volumes are not in use, let's remove them. As the comment says, the original intention was to have a different node version in the container and the host. This is something that we *don't* want. We want to use the same node version *always*, see #1319. How to test ----------- 1. Nothing to test, disabled code.
Motivation ---------- We have completely different `node --version`s on local development, build server (even in different jobs) and production. My suggestion is that we configure the node version in a central file in the root folder and reference it from everywhere. For me, any version manager is fine. If I have the choice, I suggest [asdf-vm]](https://github.com/asdf-vm/asdf). How to test ----------- 1. Check status checks
Mogge
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have completely different
node --versions on local development,build server (even in different jobs) and production.
My suggestion is that we configure the node version in a central file in
the root folder and reference it from everywhere.
For me, any version manager is fine. If I have the choice, I suggest
asdf-vm.
How to test