refactor(docker): remove unused volumes #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- These volumes are not in use, let's remove them. As the comment says, the original intention was to have a different node version in the container and the host. This is something that we *don't* want. We want to use the same node version *always*, see #1319. How to test ----------- 1. Nothing to test, disabled code.
roschaefer
force-pushed
the
remove-docker-compose-volumes
branch
from
e4593bc to
a049190
Compare
Mogge
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
These volumes are not in use, let's remove them. As the comment says,
the original intention was to have a different node version in the
container and the host.
This is something that we don't want. We want to use the same node
version always, see #1319.
How to test