Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.3 #161

Merged
merged 23 commits into from
Jan 13, 2024
Merged

v0.1.3 #161

merged 23 commits into from
Jan 13, 2024

Conversation

jiajic
Copy link
Member

@jiajic jiajic commented Jan 13, 2024

  • fixes #853
  • expose init_gobject as a param for loadGiotto() in order to skipgiotto object initialization if needed (not recommended in most cases) See ?GiottoClass::giotto for overview of what the giotto object's initialize() method does.
  • IDs are now natural sorted
  • more subobjects respond to colnames, rownames, dimnames
  • plot() (both rgl and plotly methods available through option giotto.plotengine3d) and show() now handle 3D spatLocsObj

jiajic added 23 commits January 3, 2024 11:26
- now displays calculated overlap names
Enhancement: update giottoPolygon show function
Add: images vignette and names methods
- add a link back to overarching suite package
commit 4663944
Author: jiajic <72078254+jiajic@users.noreply.github.com>
Date:   Tue Jan 9 11:02:06 2024 -0500

    Add: addCellMetadata() tests

commit 3ce570a
Author: jiajic <72078254+jiajic@users.noreply.github.com>
Date:   Tue Jan 9 10:13:01 2024 -0500

    Update NEWS.md

commit 3efa9ee
Author: jiajic <72078254+jiajic@users.noreply.github.com>
Date:   Tue Jan 9 10:09:36 2024 -0500

    chore: update documentation

commit 2d0fe0f
Author: jiajic <72078254+jiajic@users.noreply.github.com>
Date:   Fri Jan 5 12:03:42 2024 -0500

    Update auxilliary.R

commit 5cc4efa
Author: jiajic <72078254+jiajic@users.noreply.github.com>
Date:   Thu Jan 4 15:34:30 2024 -0500

    WIP
commit 9a56bfa
Author: jiajic <72078254+jiajic@users.noreply.github.com>
Date:   Fri Jan 5 16:43:45 2024 -0500

    Update methods-show.R

    spatLocsObj show now properly displays range for z col if present

commit 7976f7d
Author: jiajic <72078254+jiajic@users.noreply.github.com>
Date:   Fri Jan 5 16:30:01 2024 -0500

    Add: rgl and plotly `spatLocsObj` `plot()` methods
- update createSpatialNetwork docs
- add vignetteBuilder info to image_tools vignette
- fix unexpected metadata sorting for `addCellMetadata()` and `addFeatMetadata()`. Ordering at start of call is now matched against when returning.
testing updated to expect this behavior.
- documentation updates
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lintr found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@jiajic jiajic merged commit fca6eb3 into main Jan 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addCellMetadata performs an unexpected sort
1 participant