Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xWebSite: Move example from README.md to examples folder #487

Closed
johlju opened this issue Sep 30, 2019 · 2 comments · Fixed by #490
Closed

xWebSite: Move example from README.md to examples folder #487

johlju opened this issue Sep 30, 2019 · 2 comments · Fixed by #490
Labels
documentation The issue is related to documentation only. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/

Comments

@johlju
Copy link
Member

johlju commented Sep 30, 2019

This example https://github.com/PowerShell/xWebAdministration#create-a-new-website should be added as new example, and in the description for the comment-based help it should use the text that describing the example in the README.md.
@johlju johlju added documentation The issue is related to documentation only. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/ help wanted The issue is up for grabs for anyone in the community. in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Sep 30, 2019
This was referenced Oct 1, 2019
Merged
Merged
@tomlarse
Copy link
Contributor

tomlarse commented Oct 1, 2019

There already is a Sample_xWebsite_NewWebsite.ps1 in the /Resources/xWebsite/ folder, and there are really two configuration examples in the readme. I think the difference between the existing one and the first one from readme is only that the example in readme is configuring an HTTPS site. The second example in the readme is with a hostname for when the certificate being generated in the same configuration. Should we split them into more files maybe?

  • Sample_xWebsite_NewWebsiteHttps.ps1
  • Sample_xWebsite_NewWebsiteCertreq.ps1

Or something like that?

@johlju
Copy link
Member Author

johlju commented Oct 3, 2019

This is being worked on in PR #490

hacky1997 added a commit to hacky1997/xWebAdministration that referenced this issue Oct 5, 2019
@hacky1997
xWebSite: Moved example from README.md to examples folder dsccommunit…
e89bf30 
…y#487
hacky1997 added a commit to hacky1997/xWebAdministration that referenced this issue Oct 5, 2019
@hacky1997
xWebSite: Moved example from README.md to examples folder with the na…
f3d8b10 
…me NewWebsiteConfigure.ps1 dsccommunity#487
hacky1997 added a commit to hacky1997/xWebAdministration that referenced this issue Oct 5, 2019
@hacky1997
xWebSite: Moved example from README.md to examples folder with the Ne…
55abe8d 
…wWebsiteConfigure.ps1 dsccommunity#487
@hacky1997 hacky1997 mentioned this issue Oct 5, 2019
Merged
9 tasks
johlju pushed a commit that referenced this issue Oct 15, 2019
@hacky1997 @johlju
xWebSite: Moved localization strings, and examples from README.md (#490)
cbfa67d 
- Changes to xWebsite
  - Moved localization strings to strings.psd1 file (issue #475)
  - Move examples from README.md to resource examples folder (issue #487).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Oct 15, 2019
gstorme pushed a commit to gstorme/xWebAdministration that referenced this issue Feb 14, 2020
@hacky1997
xWebSite: Moved localization strings, and examples from README.md (ds…
702dc7f 
…ccommunity#490)

- Changes to xWebsite
  - Moved localization strings to strings.psd1 file (issue dsccommunity#475)
  - Move examples from README.md to resource examples folder (issue dsccommunity#487).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation The issue is related to documentation only. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xWebSite: Moved localization strings, and examples from README.md hacky1997/xWebAdministration
2 participants
@tomlarse @johlju