Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved example Sample_xWebsite_StopDefault out from README.md #499

Merged
merged 5 commits into from
Oct 2, 2019
Merged

Moved example Sample_xWebsite_StopDefault out from README.md #499

merged 5 commits into from
Oct 2, 2019

Conversation

tomlarse
Copy link
Contributor

@tomlarse tomlarse commented Oct 1, 2019

Pull Request (PR) description

Changes described in #486

This Pull Request (PR) fixes the following issues

fixes #486

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@tomlarse
Copy link
Contributor Author

tomlarse commented Oct 1, 2019

should probably implement #483 first?

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #499 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #499   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          17       17           
  Lines        2661     2661           
=======================================
  Hits         2432     2432           
  Misses        229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d52250...813ca39. Read the comment docs.

@johlju
Copy link
Member

johlju commented Oct 1, 2019

This works, we can implement #483 after this is merged.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tomlarse)

a discussion (no related file):
Just a tiny comment. Please update the change log with an entry explaining this change,


@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Oct 1, 2019
@johlju
Copy link
Member

johlju commented Oct 1, 2019

I will merge PR #500 before this one, I didn't realize you resolved that one too! It's awesome! 😄

@tomlarse
Copy link
Contributor Author

tomlarse commented Oct 1, 2019

Yeah, I'll update the changelog and move to the right folder structure after #500 is merged. I can take care of #485, #487 and #488 as well then if no one else has taken them.

@johlju
Copy link
Member

johlju commented Oct 1, 2019

Would be great if you can take care of the other issues as well. 😃

I will merge PR #500 as soon as the tests pass. There are so many commits pushed so the CI pipeline is behind. :)

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @tomlarse)


Examples/Sample_xWebsite_StopDefault.ps1, line 1 at r1 (raw file):

<#

Let us move this file to the correct folder now when PR #500 is merged. :)

@tomlarse
Copy link
Contributor Author

tomlarse commented Oct 1, 2019

Will do. I'll do the other ones as well. Do you want separate PR's from each, or can I put all of them here?

@johlju
Copy link
Member

johlju commented Oct 1, 2019

Do as you like. You may put all of them here if you like.

@tomlarse
Copy link
Contributor Author

tomlarse commented Oct 1, 2019

I think you can just close it now, it seems like the other ones related are already in progress :)

@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Oct 1, 2019
@johlju
Copy link
Member

johlju commented Oct 1, 2019

Ah okay! I'm having a hard time keeping up with the PRs which one resolves what. :) Then I will review this one. But will be tomorrow, it's late here now.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju changed the title EXAMPLE: Changes described in #486 Moved example Sample_xWebsite_StopDefault out from README.md Oct 2, 2019
@johlju johlju merged commit ab0a0d4 into dsccommunity:dev Oct 2, 2019
@johlju johlju removed the needs review The pull request needs a code review. label Oct 2, 2019
@johlju
Copy link
Member

johlju commented Oct 2, 2019

@tomlarse Thank you for this!

gstorme pushed a commit to gstorme/xWebAdministration that referenced this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xWebSite: Move example from README.md to examples folder
3 participants