Merge pull request #2065 from dtcenter/feature_1824_pb2nc_MLCAPE2

Feature 1996 sonarqube findings
dtcenter · Feb 23, 2022 · ba71e4c · ba71e4c
2 parents 2c4e4af + 946e4ec
commit ba71e4c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/met/src/tools/core/series_analysis/series_analysis.cc b/met/src/tools/core/series_analysis/series_analysis.cc
@@ -662,6 +662,7 @@ void process_scores() {
    VarInfo *obs_info  = (VarInfo *) 0;
    PairDataPoint *pd_ptr = (PairDataPoint *) 0;
    DataPlane fcst_dp, obs_dp;
+   const char *method_name = "process_scores() ";
 
    // Climatology mean and standard deviation
    DataPlane cmn_dp, csd_dp;
@@ -763,6 +764,12 @@ void process_scores() {
 
       } // end for i_series
 
+      if(0 == pd_ptr) {
+         mlog << Debug(3) << method_name
+              << "PairDataPoint is not set. Skip computing statistics for each grid point in the block.\n";
+         continue;
+      }
+
       // Compute statistics for each grid point in the block
       for(i=0; i<conf_info.block_size && (i_point+i)<nxy; i++) {
 

diff --git a/met/src/tools/other/pb2nc/pb2nc.cc b/met/src/tools/other/pb2nc/pb2nc.cc
@@ -1017,7 +1017,7 @@ void process_pbfile(int i_pb) {
 
    // Initialize
    prev_hdr_lat = prev_hdr_lon = prev_hdr_elv = bad_data_double;
-   cape_level = cape_count = cape_cnt_too_big = 0;
+   cape_level = cape_count = cape_cnt_too_big = cape_cnt_surface_msgs = 0;
    cape_cnt_no_levels = cape_cnt_missing_values = cape_cnt_zero_values = 0;
    mlcape_count = mlcape_cnt_too_big = 0;
    mlcape_cnt_missing_values = mlcape_cnt_zero_values = 0;