Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1996 sonarqube findings #2065

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Feature 1996 sonarqube findings #2065

merged 3 commits into from
Feb 23, 2022

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Feb 22, 2022

Expected Differences

No differences are expected except SonarQube scanning.
The SonarQube report for the Nightly build has 5 Major issues from the previous scanning. "The return after exit" will not fixed but the other 4 should be resolved.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

None except SonarQube scanning report at SonarQube MET_develop_NB

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

None. No changes at the output of unit tests.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET 10.1.0 milestone Feb 22, 2022
@hsoh-u hsoh-u linked an issue Feb 22, 2022 that may be closed by this pull request
22 tasks
@hsoh-u hsoh-u changed the title Feature 1824 pb2nc mlcape2 Feature 1996 sonarqube findings Feb 22, 2022
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this PR. I see that all the automated tests passed. I reviewed the 2 modified files and the changes look fine to me.

@hsoh-u hsoh-u merged commit ba71e4c into develop Feb 23, 2022
@JohnHalleyGotway JohnHalleyGotway deleted the feature_1824_pb2nc_MLCAPE2 branch March 17, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address findings from the SonarQube/Cppcheck code analysis tool
2 participants