Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SonarQube: Further reduce findings for MET-11.1.0-rc1 #2521

Closed
8 of 20 tasks
JohnHalleyGotway opened this issue Apr 23, 2023 · 0 comments · Fixed by #2570
Closed
8 of 20 tasks

SonarQube: Further reduce findings for MET-11.1.0-rc1 #2521

JohnHalleyGotway opened this issue Apr 23, 2023 · 0 comments · Fixed by #2570
Assignees
@hsoh-u @JohnHalleyGotway
Labels
component: code cleanup Code cleanup and maintenance issue priority: high High Priority requestor: USAF United States Air Force type: enhancement Improve something that it is currently doing
Milestone
MET 11.1.0

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Apr 23, 2023 •
edited
Loading

Describe the Enhancement

#2474 reduced the SonarQube Blocker/Major Bugs for MET version 11.1.0-beta1. This issue is to further reduce SonarQube finding for MET version 11.1.0-rc1 as much as possible.

Also note that issue #2379 will automate the running of SonarQube for each pull request submitted.

Time Estimate

Difficult to estimate. Perhaps 3 days?

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None as this time.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2771021 (METplus AirForce Funding)

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required - no scientist needed

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: code cleanup Code cleanup and maintenance issue requestor: USAF United States Air Force priority: high High Priority labels Apr 23, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Apr 23, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 📋 Backlog to 🔖 Ready in MET-11.1.0 Development Apr 23, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Further reduce SonarQube findings for MET-11.1.0-rc1 SonarQube: Further reduce findings for MET-11.1.0-rc1 Apr 23, 2023
@hsoh-u hsoh-u moved this from 🔖 Ready to 🏗 In progress in MET-11.1.0 Development Apr 24, 2023
hsoh-u pushed a commit that referenced this issue Apr 27, 2023
#2521 Changed a double pointer to DoubleArray for SonarQube
801e485
hsoh-u pushed a commit that referenced this issue Apr 27, 2023
Revert "#2521 Changed a double pointer to DoubleArray for SonarQube"
6a0209e 
This reverts commit 801e485.
hsoh-u pushed a commit that referenced this issue Apr 27, 2023
#2521 Changed module() to get_module() because module becomes a keywo…
ec92890 
…rd since C++20
hsoh-u pushed a commit that referenced this issue Apr 27, 2023
#2521 Added data_len argument to get_filtered_nc_data_2d
3eb3604
hsoh-u pushed a commit that referenced this issue Apr 27, 2023
#2521 Checks the boundary.
b2de76c
@hsoh-u hsoh-u linked a pull request Apr 27, 2023 that will close this issue
Feature 2472 sonarqube findings mtd and madis2nc #2526
Merged
15 tasks
@hsoh-u hsoh-u moved this from 🏗 In progress to 👀 In review in MET-11.1.0 Development Apr 27, 2023
@JohnHalleyGotway JohnHalleyGotway removed a link to a pull request May 5, 2023
Feature 2472 sonarqube findings mtd and madis2nc #2526
Merged
15 tasks
@JohnHalleyGotway JohnHalleyGotway mentioned this issue May 5, 2023
Merged
15 tasks
@hsoh-u hsoh-u moved this from 👀 In review to 🏗 In progress in MET-11.1.0 Development May 10, 2023
hsoh-u pushed a commit that referenced this issue May 10, 2023
#2521 Move down using statement after include
8fd7d94
hsoh-u pushed a commit that referenced this issue May 10, 2023
#2521 Remove these useless parentheses
93a11c7
hsoh-u pushed a commit that referenced this issue May 10, 2023
#2521 Move #include statement to the top of the file
ed9a5e6
hsoh-u pushed a commit that referenced this issue May 10, 2023
#2521 Move #include statement to the top of the file and removed thes…
3138e3c 
…e useless parentheses
hsoh-u pushed a commit that referenced this issue May 10, 2023
#2521 Move #include statement to the top of the file and removed thes…
54f2abb 
…e useless parentheses. used nullptr
hsoh-u pushed a commit that referenced this issue May 10, 2023
#2521 Used nullptr
6032e7b
hsoh-u pushed a commit that referenced this issue May 10, 2023
#2521 Move #include statement to the top of the file
324d3d0
hsoh-u pushed a commit that referenced this issue May 10, 2023
#2521 Appended name space std to ostream
7f31d65
hsoh-u pushed a commit that referenced this issue May 11, 2023
#2521 Added asignment operator with noexcept keyword
1e54976
hsoh-u pushed a commit that referenced this issue May 11, 2023
#2521 Added asignment operator with noexcept keyword to InputInfo
49f65b8
hsoh-u pushed a commit that referenced this issue May 11, 2023
#2521 Added asignment operator with noexcept keyword to SSIDXData
dc5ddfc
hsoh-u pushed a commit that referenced this issue May 11, 2023
#2521 Added asignment operator with noexcept keyword to ObsErrorInfo
0417e8a
hsoh-u pushed a commit that referenced this issue May 11, 2023
#2521 Added asignment operator with noexcept keyword to GenesisEventInfo
ba80c23
hsoh-u pushed a commit that referenced this issue May 11, 2023
#2521 Added asignment operator with noexcept keyword to ConvData and …
a754b74 
…RadData
hsoh-u pushed a commit that referenced this issue May 11, 2023
#2521 Added asignment operator with noexcept keyword to derive_var_cfg
577dd4f
hsoh-u pushed a commit that referenced this issue Jun 7, 2023
#2521 Refactoring to reduce the depth of if/for
5f8d794
hsoh-u pushed a commit that referenced this issue Jun 7, 2023
#2521 Refactoring to reduce the depth of if/for
564f572
hsoh-u pushed a commit that referenced this issue Jun 7, 2023
#2521 Cast to char
4377a78
hsoh-u pushed a commit that referenced this issue Jun 7, 2023
#2521 USe nullptr instead of 0
305cf34
hsoh-u pushed a commit that referenced this issue Jun 7, 2023
#2521 Added explicit to non default constructor
8ad40ac
hsoh-u pushed a commit that referenced this issue Jun 7, 2023
#2521 Release allocated memory
cf9e9a2
hsoh-u pushed a commit that referenced this issue Jun 7, 2023
#2521 applied constexpr
14d21dd
hsoh-u pushed a commit that referenced this issue Jun 7, 2023
#2521 Excluded three vaiables which are declared at basic/vx_cal/unix…
71ba7be 
…_to_mdyhms.cc
hsoh-u pushed a commit that referenced this issue Jun 7, 2023
#2521 Applied explicit & virtual
b5cc588
hsoh-u pushed a commit that referenced this issue Jun 7, 2023
#2521 Fixed code smells
8c33179
hsoh-u pushed a commit that referenced this issue Jun 12, 2023
#2521 Rolback read_bufr_vars
d0ac3f7
@JohnHalleyGotway JohnHalleyGotway linked a pull request Jun 13, 2023 that will close this issue
Feature #2521 sonarqube code smell #2570
Merged
15 tasks
JohnHalleyGotway added a commit that referenced this issue Jun 13, 2023
@JohnHalleyGotway
Per #2521, fix compilation
a822271
hsoh-u pushed a commit that referenced this issue Jun 13, 2023
#2521 Corrected nearest day at adjuste_day_for_month_year_units. Upda…
203ec34 
…ted the log messages
hsoh-u pushed a commit that referenced this issue Jun 13, 2023
#2521 MOved down using namespace below include statements
fa1b344
hsoh-u pushed a commit that referenced this issue Jun 13, 2023
#2521 Added namespace std to ofstream
2e1ab81
hsoh-u pushed a commit that referenced this issue Jun 13, 2023
#2521 Added std namespace
2ccd2ec
hsoh-u pushed a commit that referenced this issue Jun 13, 2023
#2521 Moved down using namespace below inculde statsments
5440712
hsoh-u pushed a commit that referenced this issue Jun 14, 2023
#2521 Put code back instead of calling adjuste_day_for_month_year_units
982b12b
hsoh-u pushed a commit that referenced this issue Jun 14, 2023
#2521 Put old code back at add_to_unixtime
3fa03ed
hsoh-u added a commit that referenced this issue Jun 14, 2023
@hsoh-u
Merge pull request #2570 from dtcenter/feature_2521_sonarqube_code_smell
11c7fba 
Feature #2521 sonarqube code smell
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in MET-11.1.0 Development Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsoh-u hsoh-u

@JohnHalleyGotway JohnHalleyGotway

Labels
component: code cleanup Code cleanup and maintenance issue priority: high High Priority requestor: USAF United States Air Force type: enhancement Improve something that it is currently doing
Projects
No open projects
MET-11.1.0 Development
Status: ✅ Done
Milestone
MET 11.1.0
Development

Successfully merging a pull request may close this issue.

Feature #2521 sonarqube code smell dtcenter/MET
2 participants
@hsoh-u @JohnHalleyGotway