Feature 2472 sonarqube findings mtd and madis2nc

[hsoh-u]

Resolves the SonarQube findings

• Recommended not to use "module" as a function name because it's the keyword for C++ standard V20.
• Checking boundary condition to avoid memory access errors

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  

Unittest and compared the outputs with nightly build

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

Code review

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [No]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[jprestop]

I reviewed the code changes, which were straightforward. I corrected one typo in the comments in the code. I verified that all GHA tests passed. I approve this request. Thanks for all of your work on this @hsoh-u.

[JohnHalleyGotway]

FYI, I changed the title of this PR to reference issue #2472 (SonarQube fixes for beta2) instead of #2521 (SonarQube fixes for rc1). We are recreating the beta2 release on 5/5/23 and these already merged SonarQube fixes are now included in beta2 instead of rc1.