Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance GitHub action compilation options and testing workflows #2815

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue Feb 8, 2024 · 0 comments · Fixed by #2816
Closed
8 of 21 tasks

Enhance GitHub action compilation options and testing workflows #2815

JohnHalleyGotway opened this issue Feb 8, 2024 · 0 comments · Fixed by #2816
Assignees
@JohnHalleyGotway
Labels
component: testing Software testing issue priority: high High Priority requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Milestone
MET-12.0.0

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Enhancement

Creating the MET-12.0.0-beta3 release demonstrated that the compilation options GHA workflow is not working as it should. The issue is that the ${SOURCE_BRANCH} for releases is defined as refs/tags/v12.0.0-beta3. That string is passed along to the ${MET_GIT_NAME} environment variable and used to define the path for log files. The embedded slashes in that string lead to an error that the log file is not writable.

The fix is pretty simple and easy. Update the get_branch_name.sh script to strip off ref/tags/ just like it's already stripping off refs/heads/. Note that this GHA run demonstrates that that solution fixes the problem.

In addition, incorporate these METplus changes into the MET repository.

Time Estimate

2 hours.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: testing Software testing issue requestor: METplus Team METplus Development Team priority: high High Priority labels Feb 8, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Feb 8, 2024
@JohnHalleyGotway JohnHalleyGotway self-assigned this Feb 8, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 🔖 Ready to 🏗 In progress in MET-12.0.0 Development Feb 8, 2024
JohnHalleyGotway added a commit that referenced this issue Feb 8, 2024
@JohnHalleyGotway
Per #2815, incorporate the free disk space logic from the METplus repo.
fd1ebc6
@JohnHalleyGotway JohnHalleyGotway linked a pull request Feb 8, 2024 that will close this issue
Feature #2815 gha #2816
Merged
15 tasks
JohnHalleyGotway added a commit that referenced this issue Feb 8, 2024
@JohnHalleyGotway
Feature #2815 gha (#2816)
1a1f3ac 
* When setting MET_GIT_NAME, replace embedded slashes with underscores.

* Update the MET Dockerfiles to set replace slashes with underscores when setting MET_GIT_NAME

* Revert Dockerfiles back to their original but update get_branch_name.sh to also strip off refs/tags/

* Per #2815, incorporate the free disk space logic from the METplus repo.

* Strip out the docker commands since docker is NOT installed inside the MET image.
@JohnHalleyGotway JohnHalleyGotway moved this from 🏗 In progress to 👀 In review in MET-12.0.0 Development Feb 8, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 👀 In review to ✅ Done in MET-12.0.0 Development Feb 8, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance GHA compilation options and testing workflows Enhance GitHub action compilation options and testing workflows Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnHalleyGotway JohnHalleyGotway

Labels
component: testing Software testing issue priority: high High Priority requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
No open projects
MET-12.0.0 Development
Status: 🏁 Done
Milestone
MET-12.0.0
Development

Successfully merging a pull request may close this issue.

Feature #2815 gha dtcenter/MET
1 participant
@JohnHalleyGotway