Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2815 gha #2816

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Feature #2815 gha #2816

merged 5 commits into from
Feb 8, 2024

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Created a test release named MET-12.0.0-beta3-test-compilation-options and observed this successful GHA run.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • The only real way of testing this fix is creating a test release/tag to trigger the compilation options workflow run with the problematic SOURCE_BRANCH = refs/tags/{TAGNAME} setting. Note that the workflow can be manually run for a tag... but no tag contains this fix yet. So you could create one and see that it works or rely on the testing I've already done.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    None needed.

  • Do these changes include sufficient testing updates? [Yes]
    None needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fri 2/9/24].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Feb 8, 2024
@JohnHalleyGotway JohnHalleyGotway linked an issue Feb 8, 2024 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JohnHalleyGotway JohnHalleyGotway merged commit 1a1f3ac into develop Feb 8, 2024
36 of 37 checks passed
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2815_gha branch February 8, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Enhance GitHub action compilation options and testing workflows
2 participants